-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Duplicate/nested for loop #1013
Comments
yeah, looks like one of the loops can be removed, they do the same thing. |
ronyeh
added a commit
to ronyeh/vexflow4
that referenced
this issue
Jun 2, 2021
Thanks for the sanity check @sschmidTU . I added a PR with the fix: #1014 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
vexflow/src/stringnumber.ts
Lines 52 to 58 in faf894c
It's late and I'm seeing double. :-D
While working on my PR I ran across these lines which stood out to me and just look wrong.
I believe the outer for loop can just be removed, correct? Since they both iterate on index i, by the time the inner for loop finishes, the outer one will also finish.
The text was updated successfully, but these errors were encountered: