-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering issue crash drum notation #752
Comments
This was a super thorny issue -- took three hours to figure out and fix. Running regression tests now and hope I haven't broken anything in the process. |
Thanks @0xfe for the effort looking into this. Actually the latest release (1.2.91) gives me some error. |
How are you importing the library? Can you send me reproducible sample please? |
but now only works with
|
I can confirm, the OSMD webpack build actually still compiled, but starting with Vexflow 1.2.91, when running the build/webpack server, Vex.Flow was undefined at runtime. Also, in Typescript, I had to add this to tsconfig.json (to existing compilerOptions): "compilerOptions": {
"esModuleInterop": true,
} Without that, this new import syntax was giving compile errors. Now the build is running fine and looking good, so far! It's unfortunate we weren't discussing this in a dedicated issue. |
The crash should be more to the left.
The text was updated successfully, but these errors were encountered: