Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes getTieEndX in Stave (StaveModifiers placed at the end of the Stave collide with StaveTies without end notes.) #1198

Merged
merged 2 commits into from
Oct 31, 2021

Conversation

rvilarl
Copy link
Collaborator

@rvilarl rvilarl commented Oct 24, 2021

Fixes #489

StaveTie › No End Note

before:
StaveTie No_End_Note Petaluma_Reference

after:
StaveTie No_End_Note Petaluma_Current

No other visual difference

@rvilarl rvilarl mentioned this pull request Oct 24, 2021
@rvilarl
Copy link
Collaborator Author

rvilarl commented Oct 27, 2021

@0xfe @mscuthbert this one is minor it should be a minute to merge it.

@0xfe
Copy link
Owner

0xfe commented Oct 30, 2021

Thanks Rodrigo. Does this change anything if there's no stave end modifier? Does the tie still reach the end of the stave?

@rvilarl
Copy link
Collaborator Author

rvilarl commented Oct 30, 2021

It does not produce any other visual change. Is there already a test for what you refer to? I am not sure that I really understand the case.

@0xfe
Copy link
Owner

0xfe commented Oct 30, 2021

Is there a test where the Tie begins on the last note and there's nothing on the right? (That's what the 'No End Note' test should have been, but it seems like it now ends with a stave modifier.) In that case, the tie should hit the right stave barline.

@rvilarl
Copy link
Collaborator Author

rvilarl commented Oct 30, 2021

@0xfe I have added two tests related to cases without note and without Clef both at start and at end.

I believe that the output is correct:

image

image

image

image

@rvilarl
Copy link
Collaborator Author

rvilarl commented Oct 30, 2021

@0xfe hopefully ready to merge

@0xfe
Copy link
Owner

0xfe commented Oct 31, 2021

Looks great, thanks for adding those tests!

@0xfe 0xfe merged commit a1bc011 into 0xfe:master Oct 31, 2021
@rvilarl rvilarl deleted the fix/489 branch December 27, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StaveModifiers placed at the end of the Stave collide with StaveTies without end notes.
2 participants