Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add softmax test with more extra padding #1383

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

AaronDavidNewman
Copy link
Collaborator

Show effects of softmax with larger amounts of whitespace in a measure. See discussion in PR 1376 which was cancelled and replaced with this one.

image

image

image

@rvilarl wrote in previous PR:

shouldn't we change the default from 100 to 5 as well?

That would change all the test cases. Do we want to do that?
I'm also open to making it easier to set the global softmax. It seems like it is defined in 2 places. It seemse like it should be defined in one place, either be in tables, or in the font metrics.

I would go for that, @0xfe what do you think?

Show effects of softmax with larger amounts of whitespace in a measure.
@0xfe
Copy link
Owner

0xfe commented Apr 25, 2022

Tests look good. Also, single place for global softmax sounds good, so long as we can still do local overrides.

@0xfe 0xfe merged commit 6eaad92 into 0xfe:master Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants