test: speedup re-compilation with flags #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the profile stated in our `Cargo.toml` to use `test` instead of `release`, but inheriting `release`, so we can do away with specifying the release flag on cargo test. Also toggles `incremental` to true - this is false by default in release profile and AFAIK doesn't slow down perf, but just stores more info to boost re-compilation speed.
eightfilms
requested review from
matthiasgoergens,
jdkanani,
reshmem,
vivekvpandya and
sai-deng
| @@ -23,7 +23,7 @@ jobs: | |||
| uses: ./.github/actions/rust | |||
|
|
|||
| - name: Run tests | |||
| run: cargo test --locked --all-targets --release | |||
| run: cargo test --locked --all-targets | |||
There was a problem hiding this comment.
since now you have custom profile test don't you need to use --profile test in the command ? like https://stackoverflow.com/questions/41920192/does-cargo-support-custom-profiles
or test command has its own builtin test profile ?
There was a problem hiding this comment.
Okay I see its builtin profile https://doc.rust-lang.org/cargo/reference/profiles.html
|
Based on some discussion at rust-lang/rust#57968 this seems nice to have. However if we face any issue we can revert. |
vivekvpandya
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the profile stated in our
Cargo.tomlto usetestinstead ofrelease, but inheritingrelease, so we can do away with specifying the release flag on cargo test.Also toggles
incrementalto true - this is false by default in release profile and AFAIK doesn't slow down perf, but just stores more info to boost re-compilation speed.This is easily verifiable (note that these compilations are not from scratch):
Current, running
cargo test --releaseafter making changes:This PR, running
cargo testafter making changes: