deps: Fix problematic serde by pinning to <= 1.0.171 #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: serde-rs/serde#2538 Apparently, `serde_derive` has been shipping a [non-reproducible binary](serde-rs/serde#2538 (comment)). The maintainer has also given [vague reasons](serde-rs/serde#2538 (comment)) for why they want the newer releases to use a precompiled binary. Supposedly, it helps with build time, but IMO that can't be a good enough reason to ship a precompiled binary with. Let's pin this until they decide to provide more clarity, since the future of the project/library seems uncertain.
jdkanani
approved these changes
Aug 20, 2023
|
Found further context: serde-rs/serde#2514 (comment) The maintainer is using the 10x improvement in build time to justify shipping the precompiled binary. I'm not sure if it's a good enough reason, but I suspect not. |
|
I suspect people will coalesce around a fork of serde that doesn't force pre-compiled binaries on us. |
|
@matthiasgoergens This is outdated now 😅 A new release removed the precompiled binary after all the hoo-ha. I will open a new PR to revert this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: serde-rs/serde#2538
Apparently,
serde_derivehas been shipping a non-reproducible binary.The maintainer has also given vague
reasons for why they want the newer releases to use a precompiled binary. Supposedly, it helps with build time, but IMO that can't be a good enough reason to ship a precompiled binary with.
Let's pin this until they decide to provide more clarity, since the future of the project/library seems uncertain.