Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: removed noise cancellation dependency from hmssdk and moved it to application #1808

Merged
merged 2 commits into from
Aug 6, 2024
Merged

chore: removed noise cancellation dependency from hmssdk and moved it to application #1808

merged 2 commits into from
Aug 6, 2024

Conversation

Decoder07
Copy link
Contributor

Description

  • Removed noise cancellation dependency from hmssdk and moved it to application

Pre-launch Checklist

  • The Documentation is updated accordingly, or this PR doesn't require it.
  • I updated/added relevant documentation (doc comments with ///).
  • I listed at least one issue that this PR fixes in the description above.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@Decoder07 Decoder07 requested a review from ygit August 6, 2024 10:00
@Decoder07 Decoder07 changed the title chore: Removed noise cancellation dependency from hmssdk and moved it to application chore: removed noise cancellation dependency from hmssdk and moved it to application Aug 6, 2024
ygit
ygit approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ygit ygit merged commit 7abd2da into develop Aug 6, 2024
@ygit ygit deleted the ISS-23156 branch August 6, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ygit ygit ygit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Decoder07 @ygit