fix: audio not audible when audio decode error occurs (#3289)

100mslive · Oct 9, 2024 · bba244b · bba244b
1 parent e955d49
commit bba244b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/packages/hms-video-store/src/analytics/AnalyticsEventFactory.ts b/packages/hms-video-store/src/analytics/AnalyticsEventFactory.ts
@@ -135,6 +135,16 @@ export default class AnalyticsEventFactory {
     });
   }
 
+  static audioRecovered(message: string) {
+    return new AnalyticsEvent({
+      name: 'audioRecovered',
+      level: AnalyticsEventLevel.VERBOSE,
+      properties: {
+        message,
+      },
+    });
+  }
+
   static deviceChange({
     isUserSelection,
     selection,

diff --git a/packages/hms-video-store/src/audio-sink-manager/AudioSinkManager.ts b/packages/hms-video-store/src/audio-sink-manager/AudioSinkManager.ts
@@ -136,13 +136,19 @@ export class AudioSinkManager {
       );
       this.eventBus.analytics.publish(AnalyticsEventFactory.audioPlaybackError(ex));
       if (audioEl?.error?.code === MediaError.MEDIA_ERR_DECODE) {
+        // try to wait for main execution to complete first
         this.removeAudioElement(audioEl, track);
         await sleep(500);
         await this.handleTrackAdd({ track, peer, callListener: false });
+        if (!this.state.autoplayFailed) {
+          this.eventBus.analytics.publish(
+            AnalyticsEventFactory.audioRecovered('Audio recovered after media decode error'),
+          );
+        }
       }
     };
     track.setAudioElement(audioEl);
-    track.setVolume(this.volume);
+    await track.setVolume(this.volume);
     HMSLogger.d(this.TAG, 'Audio track added', `${track}`);
     this.init(); // call to create sink element if not already created
     this.audioSink?.append(audioEl);