Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use peerId for spotlight #1597

Merged
merged 5 commits into from
Aug 11, 2023
Merged

fix: use peerId for spotlight #1597

merged 5 commits into from
Aug 11, 2023

Conversation

raviteja83
Copy link
Collaborator

@raviteja83 raviteja83 commented Aug 11, 2023

WEB-1845
Summary spotlight is not updating local peer
Type Bug Bug
Status In Progress
Points N/A
Labels qa-test

Details(context, Jira ticket, how was the bug fixed, what does the new feature do)

Choose one of these(put a 'x' in the bracket):

  • The change doesn't require a change to the documentation.
  • The documentation is updated accordingly.

Implementation note, gotchas, related work and Future TODOs (optional)

@vercel
Copy link

vercel bot commented Aug 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 7:55am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 11, 2023 7:55am

@github-actions github-actions bot added bug Something isn't working Web roomkit-react and removed bug Something isn't working Web labels Aug 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2023

size-limit report 📦

Path Size
packages/hms-video-web/dist/index.cjs.js 60.64 KB (0%)
packages/hms-video-web/dist/index.js 60.44 KB (0%)
packages/hms-video-store/dist/index.cjs.js 17.73 KB (0%)
packages/hms-video-store/dist/index.js 17.49 KB (0%)
packages/roomkit-react/dist/index.cjs.js 199.67 KB (+0.04% 🔺)
packages/roomkit-react/dist/index.js 574 B (-0.18% 🔽)
packages/hms-virtual-background/dist/index.cjs.js 5.12 KB (0%)
packages/hms-virtual-background/dist/index.js 4.91 KB (0%)
packages/hms-noise-suppression/dist/index.cjs.js 2.15 KB (0%)
packages/hms-noise-suppression/dist/index.js 1.87 KB (0%)

@github-actions github-actions bot added bug Something isn't working Web and removed bug Something isn't working Web labels Aug 11, 2023
eswarclynn
eswarclynn previously approved these changes Aug 11, 2023
@raviteja83 raviteja83 merged commit fde9687 into main Aug 11, 2023
@raviteja83 raviteja83 deleted the fix/WEB-1845-spotlight branch August 11, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants