Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: max depth error in equal prominence #1617

Merged
merged 2 commits into from
Aug 14, 2023
Merged

fix: max depth error in equal prominence #1617

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b27541
fix: max depth error
raviteja83 Aug 14, 2023
7e0e082
fix: move up initialisation
eswarclynn Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/roomkit-react/src/Prebuilt/components/EqualProminence.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export function EqualProminence() {
const [pagesWithTiles, setPagesWithTiles] = useState([]);
const [page, setPage] = useState(0);
const [ref, { width, height }] = useMeasure();
const pageSize = pagesWithTiles[0]?.length;

useEffect(() => {
// currentPageIndex should not exceed pages length
Expand Down Expand Up @@ -129,14 +130,14 @@ export function EqualProminence() {
const peersSorter = new PeersSorter(vanillaStore);
peersSorter.setPeersAndTilesPerPage({
peers,
tilesPerPage: pagesWithTiles[0]?.length || maxTileCount,
tilesPerPage: pageSize || maxTileCount,
});
peersSorter.onUpdate(setSortedPeers);

return () => {
peersSorter.stop();
};
}, [page, vanillaStore, peers, pagesWithTiles, maxTileCount]);
}, [page, vanillaStore, peers, pageSize, maxTileCount]);

return (
<Flex direction="column" css={{ flex: '1 1 0', h: '100%', position: 'relative', minWidth: 0 }}>
Expand Down