fix: remove hls.js dependency from web app and roomkit #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
raviteja83
approved these changes
Aug 16, 2023
raviteja83
approved these changes
Aug 16, 2023
raviteja83
changed the title
saikatmitra91
added a commit
that referenced
this pull request
Aug 16, 2023
* fix: header design parity and bugs * feat: minimise inset tile * fix: remove screen share and pdf share icons from react-icons (#1624) * fix: max depth error in equal prominence * fix: header design parity and bugs * fix: remove screen share and pdf share icons from react-icons * fix: image and style of screen share options component --------- Co-authored-by: Ravi theja <ravi.theja@100ms.live> * fix: remove hls.js dependency from web app and roomkit (#1622) * fix: max depth error in equal prominence * fix: header design parity and bugs * fix: web-1934: remove hls.js dependency from web app and roomkit * fix: lint error * fix: lint errors --------- Co-authored-by: Ravi theja <ravi.theja@100ms.live> * fix: show end session proper info * fix: point to qa room endpoint * feat: add endpoints to environment variables * fix: move qa endpoints to environment variabled * fix: add configurability on userid and user name --------- Co-authored-by: Ravi theja <ravi.theja@100ms.live> Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com>
saikatmitra91
added a commit
that referenced
this pull request
Aug 25, 2023
* fix: header design parity and bugs * feat: minimise inset tile * fix: remove screen share and pdf share icons from react-icons (#1624) * fix: max depth error in equal prominence * fix: header design parity and bugs * fix: remove screen share and pdf share icons from react-icons * fix: image and style of screen share options component --------- Co-authored-by: Ravi theja <ravi.theja@100ms.live> * fix: remove hls.js dependency from web app and roomkit (#1622) * fix: max depth error in equal prominence * fix: header design parity and bugs * fix: web-1934: remove hls.js dependency from web app and roomkit * fix: lint error * fix: lint errors --------- Co-authored-by: Ravi theja <ravi.theja@100ms.live> * fix: show end session proper info * fix: hide logo if broken * fix: tile design parity * feat: redesign chat UI * feat: hls player controls design update * feat: hls chat ui * fix: remove resolution popup (#1659) * fix: participants list * feat: gradient chat, remove name tags for mweb hls, fix chat for mweb hls-viewer * feat: prompt for leave * fix: leave room prompt for hls-viewer * fix: lint * fix: 2 peer layout * fix: tooltip covered by peername * feat: update toast content, actions for notifications * fix: set input type to search * fix: spacing * fix: update spacing * fix: update spacing * fix: paroty * fix: emoji reaction for mweb * fix: preview notifications * fix: css for participant count * fix: max height for menu * fix: lint errors --------- Co-authored-by: amar-1995 <110378139+amar-1995@users.noreply.github.com> Co-authored-by: Ravi theja <ravi.theja@100ms.live> Co-authored-by: Kaustubh Kumar <kaustubhkumar05@gmail.com> Co-authored-by: Eswar Prasad Clinton. A <64120992+eswarclynn@users.noreply.github.com>
saikatmitra91
added a commit
that referenced
this pull request
Aug 25, 2023
* build: update versions for release * fix: audio issue on role change * build: update versions for release * Dev to main (#1721) * fix: header design parity and bugs * feat: minimise inset tile * fix: remove screen share and pdf share icons from react-icons (#1624) * fix: max depth error in equal prominence * fix: header design parity and bugs * fix: remove screen share and pdf share icons from react-icons * fix: image and style of screen share options component --------- Co-authored-by: Ravi theja <ravi.theja@100ms.live> * fix: remove hls.js dependency from web app and roomkit (#1622) * fix: max depth error in equal prominence * fix: header design parity and bugs * fix: web-1934: remove hls.js dependency from web app and roomkit * fix: lint error * fix: lint errors --------- Co-authored-by: Ravi theja <ravi.theja@100ms.live> * fix: show end session proper info * fix: hide logo if broken * fix: tile design parity * feat: redesign chat UI * feat: hls player controls design update * feat: hls chat ui * fix: remove resolution popup (#1659) * fix: participants list * feat: gradient chat, remove name tags for mweb hls, fix chat for mweb hls-viewer * feat: prompt for leave * fix: leave room prompt for hls-viewer * fix: lint * fix: 2 peer layout * fix: tooltip covered by peername * feat: update toast content, actions for notifications * fix: set input type to search * fix: spacing * fix: update spacing * fix: update spacing * fix: paroty * fix: emoji reaction for mweb * fix: preview notifications * fix: css for participant count * fix: max height for menu * fix: lint errors --------- Co-authored-by: amar-1995 <110378139+amar-1995@users.noreply.github.com> Co-authored-by: Ravi theja <ravi.theja@100ms.live> Co-authored-by: Kaustubh Kumar <kaustubhkumar05@gmail.com> Co-authored-by: Eswar Prasad Clinton. A <64120992+eswarclynn@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Ravi theja <ravi.theja@100ms.live> Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> Co-authored-by: amar-1995 <110378139+amar-1995@users.noreply.github.com> Co-authored-by: Kaustubh Kumar <kaustubhkumar05@gmail.com> Co-authored-by: Eswar Prasad Clinton. A <64120992+eswarclynn@users.noreply.github.com>
saikatmitra91
added a commit
that referenced
this pull request
Sep 15, 2023
* fix: header design parity and bugs * feat: minimise inset tile * fix: remove screen share and pdf share icons from react-icons (#1624) * fix: max depth error in equal prominence * fix: header design parity and bugs * fix: remove screen share and pdf share icons from react-icons * fix: image and style of screen share options component --------- Co-authored-by: Ravi theja <ravi.theja@100ms.live> * fix: remove hls.js dependency from web app and roomkit (#1622) * fix: max depth error in equal prominence * fix: header design parity and bugs * fix: web-1934: remove hls.js dependency from web app and roomkit * fix: lint error * fix: lint errors --------- Co-authored-by: Ravi theja <ravi.theja@100ms.live> * fix: show end session proper info * fix: hide logo if broken * fix: tile design parity * feat: redesign chat UI * feat: hls player controls design update * feat: hls chat ui * fix: remove resolution popup (#1659) * fix: participants list * feat: gradient chat, remove name tags for mweb hls, fix chat for mweb hls-viewer * feat: prompt for leave * fix: leave room prompt for hls-viewer * fix: lint * fix: 2 peer layout * fix: tooltip covered by peername * feat: update toast content, actions for notifications * build: update versions for release * fix: set input type to search * fix: spacing * fix: update spacing * fix: update spacing * fix: paroty * fix: emoji reaction for mweb * fix: preview notifications * fix: audio issue on role change * fix: css for participant count * fix: max height for menu * build: update versions for release * Dev to main (#1718) * fix: 2 peer layout * fix: don't show inset for no publish permissions * fix: sidepane size becoming smaller * fix: z index for label * fix: add spacing in mweb grid layout * fix: hide embed url, change my role * fix: leave for viewers, common footer * fix: device settings getting clipped in mweb * fix: primary_dim token name * fix: leave room flow * fix: tile menu on mweb inset * fix: hide name in mweb hls, remove options * fix: design parity of recording * fix: minimised inset tile unresponsive in mobile * fix: flip cam showing twice * build: update versions for release * fix: audio issue on role change * build: update versions for release * fix: lint errors --------- Co-authored-by: raviteja83 <ravi.theja@100ms.live> Co-authored-by: Kaustubh Kumar <kaustubhkumar05@gmail.com> Co-authored-by: amar-1995 <110378139+amar-1995@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Dev to main (#1721) * fix: header design parity and bugs * feat: minimise inset tile * fix: remove screen share and pdf share icons from react-icons (#1624) * fix: max depth error in equal prominence * fix: header design parity and bugs * fix: remove screen share and pdf share icons from react-icons * fix: image and style of screen share options component --------- Co-authored-by: Ravi theja <ravi.theja@100ms.live> * fix: remove hls.js dependency from web app and roomkit (#1622) * fix: max depth error in equal prominence * fix: header design parity and bugs * fix: web-1934: remove hls.js dependency from web app and roomkit * fix: lint error * fix: lint errors --------- Co-authored-by: Ravi theja <ravi.theja@100ms.live> * fix: show end session proper info * fix: hide logo if broken * fix: tile design parity * feat: redesign chat UI * feat: hls player controls design update * feat: hls chat ui * fix: remove resolution popup (#1659) * fix: participants list * feat: gradient chat, remove name tags for mweb hls, fix chat for mweb hls-viewer * feat: prompt for leave * fix: leave room prompt for hls-viewer * fix: lint * fix: 2 peer layout * fix: tooltip covered by peername * feat: update toast content, actions for notifications * fix: set input type to search * fix: spacing * fix: update spacing * fix: update spacing * fix: paroty * fix: emoji reaction for mweb * fix: preview notifications * fix: css for participant count * fix: max height for menu * fix: lint errors --------- Co-authored-by: amar-1995 <110378139+amar-1995@users.noreply.github.com> Co-authored-by: Ravi theja <ravi.theja@100ms.live> Co-authored-by: Kaustubh Kumar <kaustubhkumar05@gmail.com> Co-authored-by: Eswar Prasad Clinton. A <64120992+eswarclynn@users.noreply.github.com> * fix: update color tokens * feat: prominence layout, screenshare, pinning * feat: disabled state for iconbutton options * feat: mid call preview * feat: merge main * fix: show header only when connected * fix: handle overflow in tile menu * fix: color token for screenshare label * refactor: remove template app data * fix: remove template appdata usage * fix: dataurl loader for svg * fix: update hls view * fix: role change making ui unresponsive * fix: overlay chat layout fix * fix: layout breaking * fixes: pinned message, search, remove lower hand, send button css * fix: screenshare layout, peers * fix: color variation * feat: remove chat notification * feat: use prominent layout for embed * feat: merge dev * fix: usedropdownlist for sheet * fix: show options trigger on hover * feat: viewer on stage flow * fix: empty chat img alignment * fix: go live retry * fix: lint * fix: embed layout * fix: alignment for sender name and time * fix: remove active speaker mode * fix: unused imports * fix: unused import * fix: spacing and page stuck on stop screenshare * fix: case insensitive search * fix: crash, spacing * fix: overflow in participants * fix: add check for 0 on pagination * fix: participants * fix: remove pdf url sharing * feat: add audio level animation (#1770) * feat: add audio level animation * fix: improve performance * fix: animation * fix: pip not updating dynamically (#1768) * fix: pip not updating dynamically * fix: remove test log * fix: pip and role prominence layout (#1772) * refactor: pip component * feat: Beam Layout (#1728) * feat: add hms prebuilt component to the custom app * feat: web-1952: beam layout changes * fix: components and room layout usage * fix: beam layout fixes * fix: review comment * fix: review comments * fix: add environment variables in github action * fix: pip timer error * fix: add default endpoint * feat: remove hls-viewer references (#1747) * refactor: remove hls-viewer role link * refactor: remove hls viewer * refactor: remove unused files * fix: sidepane issue * refactor: delete unused component * fix: remove unused header * fix: missing header * fix: video streaming section * refactor: leave to tsx * fix: leave session * revert: unnecessary change * fix: leave button * fix: raise hand for hls * refactor: sidepane chat * refactor: use screenType * fix: settings modal * refactor: chat * fix: build error * fix: update room layout method in prebuilt * refactor: remove streaming ui checks * fix: z index * fix: screenType in chat --------- Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> Co-authored-by: KaustubhKumar05 <kaustubhkumar05@gmail.com> * fix: spotlight not showing as role prominence * fix: missing emoji_reactions * fix: use includes for error check * fix: remove params for hls * fix: local tile not shown when no other publisher (#1780) * fix: local tile not shown when no other publisher * fix: add code comment * fix: add code comment * fix: bottom layout (#1779) * fix: hide flying emoji for hls viewer * fix: enable hls viewer and /streaming path fix * refactor: use conditionals, replace navigation * fix: add roomId and role support * fix: validation * build: update versions for alpha release * fix: inset is not getting disabled from dashboard (#1786) * fix: disable vb for mweb * fix: disable timed metadata * fix: tile spacing and blur, filter chat (#1789) * fix: tile spacing and blur * fix: handraise showing twice * fix: hide chat selector * fix: filter chat messages * fix: alignment, tab shifting * fix: design parity for participant list * fix: participant list alignment * fix: removed progress bar from player * fix: screenshare track showing video track * feat: setup environment for dev (#1795) Co-authored-by: Ravi theja <ravi.theja@100ms.live> Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> * fix: update leave css * fix: default enable av in preview * fix: page becoming unresponsive after starting stream (#1797) * fix: add test logs * refactor: extract our hls start * fix: test log * refactor: auto start streaming * fix: hls restarts after stopping * fix: infinite loop * fix: remove test logs * fix: role accordion options * fix: chat text colors * fix: tile menu icon size * fix: toggle participant list * fix: hide audio level on hls (#1804) * fix: added check for audio indicator * fix: pr comment * fix: pr comment * fix: use audio mute for audio level * fix: remove audio level --------- Co-authored-by: raviteja83 <ravi.theja@100ms.live> * fix: web-2052 not getting correct end stream message for hls viewer (#1814) * fix: update icon dimensions * fix: remove from stage should be a force action * fix: use layout api for chat * fix: preview tile video aspect ratio * fix: spacing in beam layout (#1791) * fix: remove edge space * fix: remove extra padding * feat: edge to edge * fix: aspect ratio for mweb * fix: screenshare layout for mweb * fix: add code comment * fix: use isMobile for rounded tile Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> * fix: spacing in role prominence layout * fix: spacing * fix: hide pagination * fix: spacing in screenshare --------- Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> * fix: update mid call preview properly * fix: chat, message design parity * fix: wire brb to layout * fix: blur overflow * fix: spacing between tiles for beam * fix: gradient token added * fix: emoji reactions not showing up * fix: color tokens for role accordion * fix: beam layout gap * fix: raise hand positioning * fix: on stage actions * fix: add vb to desktop, brb icon size * fix: extra tile (#1827) * fix: remove check for permissions in preview * fix: initial state for chat * fix: hide dots in pagination when there are more (#1831) * fix: hide dots if more than 5 * fix: hide dots * fix: css for network indication * fix: prominent layout, emoji reaction * fix: enter should not submit on mweb * fix: remove notifications and messages in case of recording * fix: seekbar size * fix: disable vb in mweb * fix: tooltip getting hidden * fix: disable notifications for beam * fix: secondary tile layout * fix: empty chat svg mweb * fix: viewer on stage flow * fix: enter should not join in mweb, remove chat autofocus * fix: click event not working in draggable * fix: send icon color state * fix: on stage exp mid call preview * fix: partial outline (#1846) * fix: hide tile controls for beam (#1847) * fix: web-2086: remove notifications and messages in case of beam recording & streaming * fix: review comments * fix: review comments * fix: beam notifications still visible * fix: web-2086: remove hand raise and flying emojis * fix: emoji picker colors (#1851) * fix: hls errors and listener fixes * fix: secondary tile layout * fix: stop hls stream when last broadcaster leaves * fix: remove peer, end room flow (#1849) * fix: remove peer, end room flow * fix: pr comments * fix: remove roomCode * refactor: move to custom hook * fix: mweb aspect ratio for inset * fix: height overflow * fix: role update notification * fix: web-2169: remove player controls for mweb * fix: new mesage pill flickering (#1854) * fix: new mesage pill flickering * fix: memo * fix: clean up * fix: remove icon hover state for mweb * fix: roomcode , layout updates not getting applied (#1855) * fix: preview not updating on roomcode change * refactor: migrate to tsx * fix: build error * fix: update leave room button behavior * fix: remove unused code * fix: end stream behavior --------- Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> * fix: duplicate tiles in embed * fix: delay in leave * fix: wrong options in inset tile (#1864) * fix: viewer on stage flow * fix: lower hand on role change (#1867) * feat: hls control appear on hover (#1860) * feat: hls control appear on hover * fix: remove comments * fix: remove seekbar * fix: minor typo * fix: remove flip camera for non publisher (#1868) * fix: notification count showing wrong (#1866) * fix: show going live as an overlay * fix: metadata not updating properly (#1869) * fix: metadata not updating properly * fix: pr comment Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> --------- Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> * fix: show name tile for mweb * fix: don't render tile when no track * fix: render video always * fix: remove degradation text * fix: update app links * fix: chat text color, mweb leave * fix: screenshare tile props * feat: reposition overlay chat on hide footer * build: update versions for alpha release * fix: missing screentype prop for settingsmodal * fix: staging link throwing layout api error (#1878) * fix: saving brand logo url is not reflecting on preview component (#1885) * fix: saving brand logo url is not reflecting on preview component * fix: dependency for the hook * fix: hide name for inset * fix: chat init state controlled by footer * refactor: chat participants, auto update ui (#1886) * refactor: chat participants * fix: update check for participant list * fix: vb for role change * fix: extra notification on role change decline, handraise * fix: screenshare tile controls showing in beam * fix: add null check * feat: prebuilt header * build: update versions for alpha release * fix: hls stream recover after network disconnection (#1883) * fix: hls stream recover after newtwork disconnection * fix: updated the version of hls.js * fix: handraise flow (#1896) * fix: ui for chat, participant list * fix: extra handraise notification * fix: accordion css * fix: typo, hide custom header for mweb * fix: chat/particiants tab * fix: show logo in mweb header * fix: add null check in screenshare tile * fix: overlay chat repostion on tapping * fix: show end session if endRoom permission exists * fix: 9:16 aspect ratio is not working in mweb (#1909) * fix: 9:16 aspect ratio is not working in mweb * fix: cleanup of code * fix: name typo * Update packages/hms-video-web/src/media/settings/HMSVideoTrackSettings.ts --------- Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> * fix: getting error on leaving room on prebuilt page * fix: sticky top, standard button tokens * build: update versions for alpha release * build: update versions for release * feat: merge routing hotfix to main * QA Handover PR (#1908) * feat: setup environment for dev * PR for main to dev backmerge (#1802) * fix: participant list alignment * fix: removed progress bar from player * fix: screenshare track showing video track * feat: setup environment for dev (#1795) Co-authored-by: Ravi theja <ravi.theja@100ms.live> Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> * fix: update leave css * fix: default enable av in preview * fix: page becoming unresponsive after starting stream (#1797) * fix: add test logs * refactor: extract our hls start * fix: test log * refactor: auto start streaming * fix: hls restarts after stopping * fix: infinite loop * fix: remove test logs * fix: role accordion options * fix: chat text colors * fix: tile menu icon size --------- Co-authored-by: Kaustubh Kumar <kaustubhkumar05@gmail.com> Co-authored-by: amar-1995 <110378139+amar-1995@users.noreply.github.com> Co-authored-by: Ravi theja <ravi.theja@100ms.live> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> * fix: missing constant * PR for main to dev backmerge (#1910) * fix: overlay chat repostion on tapping * fix: show end session if endRoom permission exists * fix: 9:16 aspect ratio is not working in mweb (#1909) * fix: 9:16 aspect ratio is not working in mweb * fix: cleanup of code * fix: name typo * Update packages/hms-video-web/src/media/settings/HMSVideoTrackSettings.ts --------- Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> * fix: getting error on leaving room on prebuilt page * fix: sticky top, standard button tokens * build: update versions for alpha release --------- Co-authored-by: amar-1995 <110378139+amar-1995@users.noreply.github.com> Co-authored-by: Kaustubh Kumar <kaustubhkumar05@gmail.com> Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Merge main to dev (#1924) * fix: overlay chat repostion on tapping * fix: show end session if endRoom permission exists * fix: 9:16 aspect ratio is not working in mweb (#1909) * fix: 9:16 aspect ratio is not working in mweb * fix: cleanup of code * fix: name typo * Update packages/hms-video-web/src/media/settings/HMSVideoTrackSettings.ts --------- Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> * fix: getting error on leaving room on prebuilt page * fix: sticky top, standard button tokens * build: update versions for alpha release * build: update versions for release --------- Co-authored-by: amar-1995 <110378139+amar-1995@users.noreply.github.com> Co-authored-by: Kaustubh Kumar <kaustubhkumar05@gmail.com> Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * feat: scaling changes (#1881) * feat: add room-info and session-info * fix: update room-info * feat: add groups messages * feat: add groups to peer * feat: add raise hand methods * fix: test * fix: add raise hand method to hms actions * fix: complete handraise end-to-end * fix: handraise in ui * feat: show handraise notification * feat: update connection quality handling * feat: handle peer from notifications * feat: add realtime to peer * fix: build error * fix: lower hand on role change * fix: handraise in paritcipant list * fix: format participant count * refactor: add isHandRaised to peer * fix: build error * fix: show tooltip for participant count * fix: hand raise * fix: only remove remote peers * fix: failing test * fix: peer update * fix: remove isInternalRole check on app * fix: notifications * revert: 100ms-web changes * fix: hand raise in participant list * fix: handraise for mweb * fix: remove adding peer to store on message * ci: update dev to qa * fix: chat placeholder text color (#1926) * fix: add copy link ack * fix: preview tile aligment with form * feat: main to dev backmerge * fix: show option icon on hover for inset tile on desktop * fix: simulcast bitrate (#1933) * fix:preview tile dimensions (#1932) * fix: preview tile aligment with form * fix: same width for video and form * fix: update types * fix: revert deletion * fix: allow multiple clicks on emoji * fix: move hand raise to footer for roles without av permissions (#1927) * fix: move hand raise to footer for roles without av permissions * fix: remove redundant check --------- Co-authored-by: Ravi theja <ravi.theja@100ms.live> Co-authored-by: Saikat Mitra <saikatmitra91@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Kaustubh Kumar <kaustubhkumar05@gmail.com> Co-authored-by: amar-1995 <110378139+amar-1995@users.noreply.github.com> * fix: hotfix lint error (#1939) * build: update versions for release Co-authored-by: eswarclynn <eswarclynn@users.noreply.github.com> * fix: build error * fix: build error * fix: build * fix: build * fix: build error --------- Co-authored-by: amar-1995 <110378139+amar-1995@users.noreply.github.com> Co-authored-by: Ravi theja <ravi.theja@100ms.live> Co-authored-by: Kaustubh Kumar <kaustubhkumar05@gmail.com> Co-authored-by: Eswar Prasad Clinton. A <64120992+eswarclynn@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: eswarclynn <eswarclynn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WEB-1934
Details(context, Jira ticket, how was the bug fixed, what does the new feature do)
Choose one of these(put a 'x' in the bracket):
Implementation note, gotchas, related work and Future TODOs (optional)