Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storybook env variables #1638

Merged
merged 2 commits into from
Aug 17, 2023
Merged

fix: storybook env variables #1638

merged 2 commits into from
Aug 17, 2023

Conversation

saikatmitra91
Copy link

@saikatmitra91 saikatmitra91 commented Aug 17, 2023

WEB-1946
Summary storybook environment variables not getting picked in QA
Type Bug Bug
Status In Progress
Points N/A
Labels qa-test

Details(context, Jira ticket, how was the bug fixed, what does the new feature do)

Choose one of these(put a 'x' in the bracket):

  • The change doesn't require a change to the documentation.
  • The documentation is updated accordingly.

Implementation note, gotchas, related work and Future TODOs (optional)

@vercel
Copy link

vercel bot commented Aug 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 6:24am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 17, 2023 6:24am

@github-actions github-actions bot added bug Something isn't working Web roomkit-react and removed bug Something isn't working Web labels Aug 17, 2023
@github-actions github-actions bot added bug Something isn't working Web and removed bug Something isn't working Web labels Aug 17, 2023
@raviteja83 raviteja83 changed the title fix: web-1946 fix: storybook env variables Aug 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 17, 2023

size-limit report 📦

Path Size
packages/hms-video-web/dist/index.cjs.js 60.64 KB (0%)
packages/hms-video-web/dist/index.js 60.44 KB (0%)
packages/hms-video-store/dist/index.cjs.js 17.72 KB (0%)
packages/hms-video-store/dist/index.js 17.48 KB (0%)
packages/roomkit-react/dist/index.cjs.js 250.17 KB (+0.01% 🔺)
packages/roomkit-react/dist/index.js 561 B (+0.54% 🔺)
packages/hms-virtual-background/dist/index.cjs.js 5.12 KB (0%)
packages/hms-virtual-background/dist/index.js 4.91 KB (0%)
packages/react-icons/dist/index.cjs.js 63.95 KB (0%)
packages/react-icons/dist/index.js 2.02 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants