fix: end session should stop stream #1667
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
raviteja83
reviewed
Aug 22, 2023
| hmsActions.endRoom(false, 'End Room'); | ||
| redirectToLeavePage(); | ||
| }; | ||
| // const endRoom = () => { |
There was a problem hiding this comment.
remove if not needed. wouldn't it be needed if stream is not running?
There was a problem hiding this comment.
Blocked, waiting for a response: https://100ms-live.slack.com/archives/C051V3WF2FM/p1692716885227799?thread_ts=1692691760.163499&cid=C051V3WF2FM
There was a problem hiding this comment.
The query has been resolved. End room will be needed only for webrtc. Will update
There was a problem hiding this comment.
Raised fix PR against main here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.