Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: audio video settings getting clipped in mweb #1680

Merged
merged 6 commits into from
Aug 23, 2023

Conversation

KaustubhKumar05
Copy link
Collaborator

@KaustubhKumar05 KaustubhKumar05 commented Aug 22, 2023

WEB-1993
Summary audio video options are not visible on mweb under device settings
Type Bug Bug
Status In Progress
Points N/A
Labels prebuilt, qa-test

Details(context, Jira ticket, how was the bug fixed, what does the new feature do)

Choose one of these(put a 'x' in the bracket):

  • The change doesn't require a change to the documentation.
  • The documentation is updated accordingly.

Implementation note, gotchas, related work and Future TODOs (optional)

@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 5:32am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2023 5:32am

@KaustubhKumar05 KaustubhKumar05 marked this pull request as ready for review August 22, 2023 16:01
@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2023

size-limit report 📦

Path Size
packages/hms-video-web/dist/index.cjs.js 60.64 KB (0%)
packages/hms-video-web/dist/index.js 60.44 KB (0%)
packages/hms-video-store/dist/index.cjs.js 17.72 KB (0%)
packages/hms-video-store/dist/index.js 17.48 KB (0%)
packages/roomkit-react/dist/index.cjs.js 250.3 KB (+0.01% 🔺)
packages/roomkit-react/dist/index.js 563 B (+0.72% 🔺)
packages/hms-virtual-background/dist/index.cjs.js 5.12 KB (0%)
packages/hms-virtual-background/dist/index.js 4.91 KB (0%)
packages/react-icons/dist/index.cjs.js 63.95 KB (0%)
packages/react-icons/dist/index.js 2.02 KB (0%)

@raviteja83 raviteja83 merged commit 5f618d1 into main Aug 23, 2023
@raviteja83 raviteja83 deleted the WEB-1993-settings-mweb branch August 23, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working roomkit-react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants