Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spacing and page stuck on stop screenshare #1762

Merged
merged 2 commits into from
Aug 30, 2023
Merged

Conversation

raviteja83
Copy link
Collaborator

@raviteja83 raviteja83 commented Aug 30, 2023

Details(context, Jira ticket, how was the bug fixed, what does the new feature do)

Choose one of these(put a 'x' in the bracket):

  • The change doesn't require a change to the documentation.
  • The documentation is updated accordingly.

Implementation note, gotchas, related work and Future TODOs (optional)

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 11:24am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 11:24am

@github-actions
Copy link
Contributor

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: fix/spacing

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

@raviteja83 raviteja83 merged commit 77e3bcb into main Aug 30, 2023
@raviteja83 raviteja83 deleted the fix/spacing branch August 30, 2023 11:25
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/hms-video-web/dist/index.cjs.js 60.93 KB (0%)
packages/hms-video-web/dist/index.js 60.73 KB (0%)
packages/hms-video-store/dist/index.cjs.js 17.76 KB (0%)
packages/hms-video-store/dist/index.js 17.54 KB (0%)
packages/roomkit-react/dist/index.cjs.js 202.56 KB (+0.01% 🔺)
packages/roomkit-react/dist/index.js 547 B (-0.55% 🔽)
packages/hms-virtual-background/dist/index.cjs.js 5.12 KB (0%)
packages/hms-virtual-background/dist/index.js 4.91 KB (0%)
packages/react-icons/dist/index.cjs.js 64.57 KB (0%)
packages/react-icons/dist/index.js 2.03 KB (0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants