Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update and hide degradation text for hls viewer #1870

Closed
wants to merge 1 commit into from

Conversation

KaustubhKumar05
Copy link
Collaborator

@KaustubhKumar05 KaustubhKumar05 commented Sep 7, 2023

WEB-2194
Summary network unstable on tiles is appearing in stream
Type Bug Bug
Status In Progress
Points N/A
Labels prebuilt

image

Updated text and css
https://100ms.atlassian.net/browse/WEB-2160

@vercel
Copy link

vercel bot commented Sep 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:51am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 7, 2023 0:51am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

size-limit report 📦

Path Size
packages/hms-video-web/dist/index.cjs.js 60.95 KB (0%)
packages/hms-video-web/dist/index.js 60.75 KB (0%)
packages/hms-video-store/dist/index.cjs.js 17.8 KB (0%)
packages/hms-video-store/dist/index.js 17.56 KB (0%)
packages/roomkit-react/dist/index.cjs.js 202.79 KB (+0.02% 🔺)
packages/roomkit-react/dist/index.js 551 B (+0.19% 🔺)
packages/hms-virtual-background/dist/index.cjs.js 5.12 KB (0%)
packages/hms-virtual-background/dist/index.js 4.92 KB (0%)
packages/react-icons/dist/index.cjs.js 64.57 KB (0%)
packages/react-icons/dist/index.js 2.03 KB (0%)

@@ -42,6 +42,7 @@ const Tile = ({
roundedVideoTile = true,
hideAudioMuteOnTile = false,
hideMetadataOnTile = false,
hideDegradationText = false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can use the metadata value itself

@KaustubhKumar05
Copy link
Collaborator Author

Closing this, #1874 can be reviewed instead
cc @raviteja83 @saikatmitra91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants