Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show option icon on hover in inset tile for desktop #1916

Merged
merged 8 commits into from
Sep 14, 2023
Merged

fix: show option icon on hover in inset tile for desktop #1916

merged 8 commits into from
Sep 14, 2023

Conversation

amar-1995
Copy link
Contributor

@amar-1995 amar-1995 commented Sep 13, 2023 •
edited by github-actions bot
Loading

WEB-2229
Summary Options Menu on local tile should come only on hover
Type Bug Bug
Status In Progress
Points N/A
Labels prebuilt

This PR:

  1. Show option icon only on hover in inset tile for desktop
  2. In mweb always show the option icon in the inset tile. Reason touch and click behave the same on mweb hence can't distinguish the diff between drag and click.

@vercel
Copy link

vercel bot commented Sep 13, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 8:08am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 8:08am

@github-actions github-actions bot added bug Something isn't working Web roomkit-react and removed bug Something isn't working Web labels Sep 13, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/hms-video-web/dist/index.cjs.js 61 KB (0%)
packages/hms-video-web/dist/index.js 60.79 KB (0%)
packages/hms-video-store/dist/index.cjs.js 17.8 KB (0%)
packages/hms-video-store/dist/index.js 17.56 KB (0%)
packages/roomkit-react/dist/index.cjs.js 202.88 KB (+0.01% 🔺)
packages/roomkit-react/dist/index.js 549 B (-0.19% 🔽)
packages/hms-virtual-background/dist/index.cjs.js 5.12 KB (0%)
packages/hms-virtual-background/dist/index.js 4.92 KB (0%)
packages/react-icons/dist/index.cjs.js 64.57 KB (0%)
packages/react-icons/dist/index.js 2.03 KB (0%)

@raviteja83 raviteja83 changed the base branch from main to dev September 14, 2023 07:48
@github-actions github-actions bot added bug Something isn't working Web labels Sep 14, 2023
@raviteja83 raviteja83 merged commit f71b35f into dev Sep 14, 2023
3 of 4 checks passed
@raviteja83 raviteja83 deleted the WEB-2229-option-icon-on-inset-tile branch September 14, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raviteja83 raviteja83 raviteja83 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working roomkit-react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amar-1995 @raviteja83 @KaustubhKumar05 @saikatmitra91