Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: joining loader in beam end room #1976

Merged
merged 5 commits into from
Sep 28, 2023

Conversation

KaustubhKumar05
Copy link
Collaborator

@KaustubhKumar05 KaustubhKumar05 commented Sep 22, 2023

LIVE-1722
Summary Slice - End room is causing joining loader at the end of the recording
Type Bug Bug
Status In Progress
Points N/A
Labels customer_issuesv2, prebuilt

Details(context, Jira ticket, how was the bug fixed, what does the new feature do)

Choose one of these(put a 'x' in the bracket):

  • The change doesn't require a change to the documentation.
  • The documentation is updated accordingly.

Implementation note, gotchas, related work and Future TODOs (optional)

@vercel
Copy link

vercel bot commented Sep 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 10:56am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 10:56am

@github-actions github-actions bot added bug Something isn't working LIVE and removed bug Something isn't working LIVE labels Sep 22, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

size-limit report 📦

Path Size
packages/hms-video-web/dist/index.cjs.js 62.16 KB (0%)
packages/hms-video-web/dist/index.js 61.93 KB (0%)
packages/hms-video-store/dist/index.cjs.js 18.09 KB (0%)
packages/hms-video-store/dist/index.js 17.88 KB (0%)
packages/roomkit-react/dist/index.cjs.js 206.22 KB (+0.08% 🔺)
packages/roomkit-react/dist/index.js 552 B (-0.19% 🔽)
packages/hms-virtual-background/dist/index.cjs.js 5.12 KB (0%)
packages/hms-virtual-background/dist/index.js 4.92 KB (0%)
packages/react-icons/dist/index.cjs.js 64.58 KB (0%)
packages/react-icons/dist/index.js 2.03 KB (0%)

@raviteja83 raviteja83 merged commit 20f4938 into main Sep 28, 2023
7 checks passed
@raviteja83 raviteja83 deleted the LIVE-1722-end-room-joining-loader branch September 28, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants