fix: prompt for page refresh, tab close #1987

KaustubhKumar05 · 2023-09-26T07:24:07Z

Summary	mweb: Page refresh is kicking the peer out of room \| Prompt for confirmation
Type	Bug
Status	In Progress
Points	N/A
Labels	go-live-issue, prebuilt

vercel · 2023-09-26T07:24:13Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
dashboard-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 28, 2023 5:17am
storybook-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 28, 2023 5:17am

packages/react-sdk/src/primitives/HmsRoomProvider.ts

packages/roomkit-react/src/Prebuilt/App.tsx

apps/100ms-custom-app/src/App.jsx

resolved

fix: prompt for page refresh, tab close

d4e94f3

KaustubhKumar05 requested a review from raviteja83 as a code owner September 26, 2023 07:24

github-actions bot added bug Something isn't working Web labels Sep 26, 2023

vercel bot deployed to Preview – dashboard-app September 26, 2023 07:27 View deployment

vercel bot deployed to Preview – storybook-app September 26, 2023 07:27 View deployment

KaustubhKumar05 requested a review from saikatmitra91 September 26, 2023 09:48

fix: move leave to unload

eccd2cd

vercel bot deployed to Preview – storybook-app September 27, 2023 06:19 View deployment

vercel bot deployed to Preview – dashboard-app September 27, 2023 06:19 View deployment

fix: lint

00eef5d

vercel bot deployed to Preview – storybook-app September 27, 2023 06:51 View deployment

vercel bot deployed to Preview – dashboard-app September 27, 2023 06:51 View deployment

raviteja83 reviewed Sep 27, 2023

View reviewed changes

packages/react-sdk/src/primitives/HmsRoomProvider.ts Show resolved Hide resolved

saikatmitra91 previously requested changes Sep 28, 2023

View reviewed changes

packages/roomkit-react/src/Prebuilt/App.tsx Outdated Show resolved Hide resolved

fix: move prompt to custom app

3a0383b

vercel bot deployed to Preview – dashboard-app September 28, 2023 05:17 View deployment

vercel bot deployed to Preview – storybook-app September 28, 2023 05:17 View deployment

KaustubhKumar05 requested review from raviteja83 and saikatmitra91 September 28, 2023 05:54

raviteja83 approved these changes Sep 28, 2023

View reviewed changes

raviteja83 reviewed Sep 28, 2023

View reviewed changes

apps/100ms-custom-app/src/App.jsx Show resolved Hide resolved

raviteja83 merged commit a8071b4 into dev Sep 28, 2023
4 checks passed

raviteja83 deleted the WEB-2143-refresh-prompt branch September 28, 2023 11:02

Provide feedback