Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate error code #2019

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix: duplicate error code #2019

merged 1 commit into from
Oct 4, 2023

Conversation

KaustubhKumar05
Copy link
Collaborator

Details(context, Jira ticket, how was the bug fixed, what does the new feature do)

  • Two errors share 3008, assigned 3004 to the one in serial order
  • The documentation is updated accordingly.

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 9:34am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 9:34am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

A JIRA Issue ID is missing from your branch name! 🦄

Your branch: FIX-DUPLICATE-ERROR-CODE

If this is your first time contributing to this repository - welcome!


Please refer to jira-lint to get started.

Without the JIRA Issue ID in your branch name you would lose out on automatic updates to JIRA via SCM; some GitHub status checks might fail.

Valid sample branch names:

‣ feature/shiny-new-feature--mojo-10'
‣ 'chore/changelogUpdate_mojo-123'
‣ 'bugfix/fix-some-strange-bug_GAL-2345'

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

size-limit report 📦

Path Size
packages/hms-video-web/dist/index.cjs.js 62.08 KB (+0.01% 🔺)
packages/hms-video-web/dist/index.js 61.85 KB (+0.01% 🔺)
packages/hms-video-store/dist/index.cjs.js 18.03 KB (0%)
packages/hms-video-store/dist/index.js 17.81 KB (0%)
packages/roomkit-react/dist/index.cjs.js 206.4 KB (-0.01% 🔽)
packages/roomkit-react/dist/index.js 552 B (+0.19% 🔺)
packages/hms-virtual-background/dist/index.cjs.js 5.12 KB (0%)
packages/hms-virtual-background/dist/index.js 4.91 KB (0%)
packages/react-icons/dist/index.cjs.js 64.58 KB (0%)
packages/react-icons/dist/index.js 2.03 KB (0%)

@raviteja83 raviteja83 self-requested a review October 4, 2023 09:47
@raviteja83 raviteja83 merged commit a846271 into main Oct 4, 2023
5 of 7 checks passed
@raviteja83 raviteja83 deleted the FIX-DUPLICATE-ERROR-CODE branch October 4, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants