Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add prompt for mweb landscape mode #2021

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Conversation

KaustubhKumar05
Copy link
Collaborator

@KaustubhKumar05 KaustubhKumar05 commented Oct 4, 2023

WEB-2190
Summary Prompt for mweb landscape
Type Bug Bug
Status In Progress
Points N/A
Labels go-live-issue, prebuilt

Details(context, Jira ticket, how was the bug fixed, what does the new feature do)

Choose one of these(put a 'x' in the bracket):

  • The change doesn't require a change to the documentation.
  • The documentation is updated accordingly.

Implementation note, gotchas, related work and Future TODOs (optional)

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 11:28am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 11:28am

@github-actions github-actions bot added bug Something isn't working Web and removed bug Something isn't working Web labels Oct 4, 2023
@KaustubhKumar05 KaustubhKumar05 changed the title fix: logging fix: add prompt for mweb landscape mode Oct 4, 2023
@KaustubhKumar05 KaustubhKumar05 marked this pull request as ready for review October 4, 2023 11:22
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

size-limit report 📦

Path Size
packages/hms-video-web/dist/index.cjs.js 62.08 KB (0%)
packages/hms-video-web/dist/index.js 61.85 KB (0%)
packages/hms-video-store/dist/index.cjs.js 18.03 KB (0%)
packages/hms-video-store/dist/index.js 17.81 KB (0%)
packages/roomkit-react/dist/index.cjs.js 206.75 KB (+0.17% 🔺)
packages/roomkit-react/dist/index.js 551 B (-0.19% 🔽)
packages/hms-virtual-background/dist/index.cjs.js 5.12 KB (0%)
packages/hms-virtual-background/dist/index.js 4.91 KB (0%)
packages/react-icons/dist/index.cjs.js 64.58 KB (0%)
packages/react-icons/dist/index.js 2.03 KB (0%)

@raviteja83 raviteja83 merged commit f0f9bf9 into main Oct 4, 2023
6 of 7 checks passed
@raviteja83 raviteja83 deleted the WEB-2190-prompt-fix branch October 4, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants