Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handraise type error, migrate notifications to tsx #2024

Merged
merged 2 commits into from
Oct 9, 2023
Merged

fix: handraise type error, migrate notifications to tsx #2024

merged 2 commits into from
Oct 9, 2023

Conversation

raviteja83
Copy link
Collaborator

@raviteja83 raviteja83 commented Oct 6, 2023 •
edited by github-actions bot
Loading

WEB-2310
Summary Type error for new handraise notification
Type Bug Bug
Status In Progress
Points N/A
Labels -

Details(context, Jira ticket, how was the bug fixed, what does the new feature do)

Choose one of these(put a 'x' in the bracket):

  • The change doesn't require a change to the documentation.
  • The documentation is updated accordingly.

Implementation note, gotchas, related work and Future TODOs (optional)

@vercel
Copy link

vercel bot commented Oct 6, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 10:48am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 10:48am

@raviteja83 raviteja83 changed the title refactor: migrate notifications to tsx fix: handraise type error, migrate notifications to tsx Oct 6, 2023
@github-actions github-actions bot added bug Something isn't working Web labels Oct 6, 2023
@raviteja83 raviteja83 merged commit 075ff62 into dev Oct 9, 2023
4 checks passed
@raviteja83 raviteja83 deleted the fix/WEB-2310-type-error branch October 9, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eswarclynn eswarclynn eswarclynn approved these changes

@KaustubhKumar05 KaustubhKumar05 KaustubhKumar05 approved these changes

@saikatmitra91 saikatmitra91 Awaiting requested review from saikatmitra91

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raviteja83 @KaustubhKumar05 @eswarclynn