Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use initialised_at #2029

Merged
merged 9 commits into from
Oct 12, 2023
Merged

fix: use initialised_at #2029

merged 9 commits into from
Oct 12, 2023

Conversation

KaustubhKumar05
Copy link
Collaborator

@KaustubhKumar05 KaustubhKumar05 commented Oct 10, 2023 •
edited
Loading

WEB-2308
Summary Use initialized at from hls-init to show Live timer
Type Task Task
Status In Progress
Points N/A
Labels -

Choose one of these(put a 'x' in the bracket):

  • The change doesn't require a change to the documentation.
  • The documentation is updated accordingly.

Changes

  • initialised_at will be used to manage stream timer for broadcasters
  • hls-viewers will still see started_at time
  • Discussion thread

@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 11:04am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 11:04am

@KaustubhKumar05 KaustubhKumar05 marked this pull request as ready for review October 11, 2023 09:26
amar-1995
amar-1995 reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@amar-1995 amar-1995 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked where recording is enabled for hls streaming. There we will get delay of 4 sec between init and start, you can see in that time frame live icon is not shown.

@raviteja83 raviteja83 merged commit da33290 into dev Oct 12, 2023
4 checks passed
@raviteja83 raviteja83 deleted the WEB-2308 branch October 12, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amar-1995 amar-1995 amar-1995 approved these changes

@raviteja83 raviteja83 raviteja83 approved these changes

@saikatmitra91 saikatmitra91 Awaiting requested review from saikatmitra91

@eswarclynn eswarclynn Awaiting requested review from eswarclynn

Assignees

@amar-1995 amar-1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaustubhKumar05 @raviteja83 @amar-1995