Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add error message for peerlist iterator #2051

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

raviteja83
Copy link
Collaborator

@raviteja83 raviteja83 commented Oct 18, 2023

WEB-2330
Summary Throw an error when peerlist iterator is used before calling preview or join
Type Incident Incident
Status In Progress
Points N/A
Labels -

Details(context, Jira ticket, how was the bug fixed, what does the new feature do)

Choose one of these(put a 'x' in the bracket):

  • The change doesn't require a change to the documentation.
  • The documentation is updated accordingly.

Implementation note, gotchas, related work and Future TODOs (optional)

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview Oct 18, 2023 5:47am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 5:47am

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/hms-video-web/dist/index.cjs.js 62.87 KB (+0.08% 🔺)
packages/hms-video-web/dist/index.js 62.64 KB (+0.08% 🔺)
packages/hms-video-store/dist/index.cjs.js 18.03 KB (0%)
packages/hms-video-store/dist/index.js 17.81 KB (0%)
packages/roomkit-react/dist/index.cjs.js 205.68 KB (+0.01% 🔺)
packages/roomkit-react/dist/index.js 564 B (+0.18% 🔺)
packages/hms-virtual-background/dist/index.cjs.js 5.12 KB (0%)
packages/hms-virtual-background/dist/index.js 4.91 KB (0%)
packages/react-icons/dist/index.cjs.js 64.58 KB (0%)
packages/react-icons/dist/index.js 2.03 KB (0%)

@raviteja83 raviteja83 merged commit 349472e into main Oct 19, 2023
6 of 7 checks passed
@raviteja83 raviteja83 deleted the fix/WEB-2330-iterator-error branch October 19, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants