Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: localStorage restriction should not be terminal #2103

Merged
merged 9 commits into from
Nov 8, 2023
Merged

fix: localStorage restriction should not be terminal #2103

merged 9 commits into from
Nov 8, 2023

Conversation

KaustubhKumar05
Copy link
Collaborator

@KaustubhKumar05 KaustubhKumar05 commented Nov 7, 2023 •
edited by github-actions bot
Loading

WEB-2337
Summary zingly - DOMException: Failed to read the ‘localStorage’ property from ‘Window’: Access is denied for this document.
Type Incident Incident
Status In Progress
Points N/A
Labels -
  • Need to avoid direct reference to window.localStorage in iframe and when it is restricted (incognito with cookies and localStorage access disabled)
  • Verified normal flow: Joining, going live, interacting with the room and rejoin
image

@vercel Vercel
Copy link

vercel bot commented Nov 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 6:08am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2023 6:08am

@KaustubhKumar05 KaustubhKumar05 changed the title test: deploy with logs fix: localStorage restriction should not be terrminal Nov 7, 2023
@KaustubhKumar05 KaustubhKumar05 marked this pull request as ready for review November 7, 2023 11:26
@KaustubhKumar05 KaustubhKumar05 changed the title fix: localStorage restriction should not be terrminal fix: localStorage restriction should not be terminal Nov 7, 2023
saikatmitra91
saikatmitra91 previously requested changes Nov 8, 2023
View reviewed changes
packages/hms-video-web/src/error/ErrorFactory.ts Outdated Show resolved Hide resolved
@raviteja83 raviteja83 merged commit 37cf3dc into dev Nov 8, 2023
5 of 6 checks passed
@raviteja83 raviteja83 deleted the WEB-2337-localstorage branch November 8, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raviteja83 raviteja83 raviteja83 approved these changes

@saikatmitra91 saikatmitra91 Awaiting requested review from saikatmitra91

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaustubhKumar05 @raviteja83 @saikatmitra91