-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: interruption events #3122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
amar-1995
requested review from
raviteja83,
eswarclynn and
KaustubhKumar05
as code owners
July 24, 2024 14:08
amar-1995
changed the title
Feat/web 2945 interruption events
feat: interruption events
Jul 24, 2024
raviteja83
reviewed
Jul 24, 2024
packages/hms-video-store/src/media/tracks/HMSLocalAudioTrack.ts
Outdated
Show resolved
Hide resolved
raviteja83
reviewed
Jul 24, 2024
packages/hms-video-store/src/media/tracks/HMSLocalAudioTrack.ts
Outdated
Show resolved
Hide resolved
raviteja83
reviewed
Jul 24, 2024
packages/hms-video-store/src/analytics/AnalyticsEventFactory.ts
Outdated
Show resolved
Hide resolved
AudioSinkManager also has interuption that also has to be handled. |
raviteja83
reviewed
Jul 25, 2024
packages/hms-video-store/src/analytics/AnalyticsEventFactory.ts
Outdated
Show resolved
Hide resolved
raviteja83
reviewed
Jul 26, 2024
raviteja83
approved these changes
Jul 31, 2024
eswarclynn
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details(context, link the issue, how was the bug fixed, what does the new feature do)
Implementation note, gotchas, related work and Future TODOs (optional)