Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip permissions if headless #3176

Merged
merged 2 commits into from
Aug 13, 2024
Merged

fix: skip permissions if headless #3176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b840687
fix: skip permissions if headless
KaustubhKumar05 Aug 13, 2024
30ceee7
fix: check
KaustubhKumar05 Aug 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/hms-video-store/src/transport/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,10 +786,6 @@ export default class HMSTransport {
const log = newState === 'disconnected' ? HMSLogger.w.bind(HMSLogger) : HMSLogger.d.bind(HMSLogger);
log(TAG, `Subscribe ice connection state change: ${newState}`);

// if (newState === 'failed') {
// // await this.handleIceConnectionFailure(HMSConnectionRole.Subscribe);
// }

if (newState === 'connected') {
const callback = this.callbacks.get(SUBSCRIBE_ICE_CONNECTION_CALLBACK_ID);
this.callbacks.delete(SUBSCRIBE_ICE_CONNECTION_CALLBACK_ID);
Expand Down
4 changes: 4 additions & 0 deletions packages/react-sdk/src/hooks/useAwayNotifications.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ import { useHMSVanillaStore } from '../primitives/HmsRoomProvider';
export const useAwayNotifications = () => {
const vanillaStore = useHMSVanillaStore();
const requestPermission = useCallback(async () => {
// Headless check for beam
if (navigator.webdriver) {
return;
KaustubhKumar05 marked this conversation as resolved.
Show resolved Hide resolved
}
if (!Notification || Notification?.permission === 'granted' || Notification?.permission === 'denied') {
return;
}
Expand Down
Loading