Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add an event when tracks are published with no data #3298

Merged
merged 15 commits into from
Oct 8, 2024
Merged

fix: add an event when tracks are published with no data #3298

merged 15 commits into from
Oct 8, 2024

Conversation

raviteja83
Copy link
Collaborator

Details(context, link the issue, how was the bug fixed, what does the new feature do)

  • Handle possible scenarios where this can be recovered
  • Happens when whatsapp call is already happening and 100ms link is joined on iOS mweb.

Implementation note, gotchas, related work and Future TODOs (optional)

@vercel Vercel
Copy link

vercel bot commented Oct 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 11:52am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 8, 2024 11:52am

@raviteja83 raviteja83 marked this pull request as draft October 5, 2024 07:05
@raviteja83 raviteja83 self-assigned this Oct 8, 2024
@raviteja83 raviteja83 marked this pull request as ready for review October 8, 2024 05:56
ygit
ygit previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@ygit ygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raviteja83 raviteja83 changed the title fix: add an event when no tracks are published fix: add an event when tracks are published with no data Oct 8, 2024
@KaustubhKumar05 KaustubhKumar05 merged commit bc76e24 into dev Oct 8, 2024
2 of 4 checks passed
@KaustubhKumar05 KaustubhKumar05 deleted the fix/WEB-3041-no-track-publish branch October 8, 2024 11:47
raviteja83 added a commit that referenced this pull request Oct 9, 2024
@raviteja83 @ygit
fix: add an event when tracks are published with no data (#3298)
b66b4ec 
Co-authored-by: Yogesh Singh <yogesh@100ms.live>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hdz-666 hdz-666 hdz-666 left review comments

@KaustubhKumar05 KaustubhKumar05 KaustubhKumar05 approved these changes

@ygit ygit ygit approved these changes

@eswarclynn eswarclynn Awaiting requested review from eswarclynn

@amar-1995 amar-1995 Awaiting requested review from amar-1995

Assignees

@raviteja83 raviteja83

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@raviteja83 @ygit @KaustubhKumar05 @hdz-666