Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add trackType to track related errors #3350

Merged
merged 21 commits into from
Oct 31, 2024
Merged

fix: add trackType to track related errors #3350

merged 21 commits into from
Oct 31, 2024

Conversation

hdz-666
Copy link
Collaborator

@hdz-666 hdz-666 commented Oct 29, 2024 •
edited
Loading

Details(context, link the issue, how was the bug fixed, what does the new feature do)

  • create HMSTrackException extendind from class HMSException and add trackType prop to constructor
  • Modify GetMediaError function to throw HMSTrackException
  • Export enum HSMTrackExceptionTrackType from react-sdk
  • Replace and handle using track_type instead of message.includes() in prebuilt
  • UseHMSNotifiaction to have the error type throw both classes for exception

Implementation note, gotchas, related work and Future TODOs (optional)

@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 11:42am
storybook-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 11:42am

@hdz-666 hdz-666 changed the base branch from main to dev October 29, 2024 08:49
@KaustubhKumar05 KaustubhKumar05 requested a review from ygit October 29, 2024 09:53
gzerad
gzerad previously approved these changes Oct 31, 2024
View reviewed changes
@hdz-666 hdz-666 requested a review from raviteja83 October 31, 2024 10:47
@raviteja83 raviteja83 changed the title add track type in hms exception for media errors fix: add trackType to track related errors Oct 31, 2024
@KaustubhKumar05 KaustubhKumar05 merged commit fcd2027 into dev Oct 31, 2024
4 checks passed
@KaustubhKumar05 KaustubhKumar05 deleted the feat/WEB-3058-add-new-track-type-in-hmsException branch October 31, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaustubhKumar05 KaustubhKumar05 KaustubhKumar05 approved these changes

@raviteja83 raviteja83 raviteja83 approved these changes

@amar-1995 amar-1995 Awaiting requested review from amar-1995

@ygit ygit Awaiting requested review from ygit

@gzerad gzerad Awaiting requested review from gzerad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hdz-666 @gzerad @raviteja83 @KaustubhKumar05