fix: upgrade ua-parser-js to track correct device models #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/hms-video-store/src/sdk/index.ts # packages/hms-video-store/src/utils/support.ts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
raviteja83
reviewed
Dec 9, 2024
| headers: { | ||
| 'Content-Type': 'application/json', | ||
| Authorization: `Bearer ${event.metadata.token}`, | ||
| user_agent_v2: event.metadata.userAgent, |
raviteja83
reviewed
Dec 9, 2024
| @@ -15,7 +15,7 @@ export interface HMSSessionFeedback { | |||
|
|
|||
| export interface HMSSessionInfo { | |||
| peer: HMSSessionPeerInfo; | |||
| agent: string; | |||
| agent?: string; | |||
There was a problem hiding this comment.
most likely should not be optional
raviteja83
reviewed
Dec 9, 2024
| export const isIOS = parsedUserAgent.getOS()?.name?.toLowerCase() === 'ios'; | ||
| export const isMacOS = parsedUserAgent.getOS()?.name?.toLowerCase() === 'mac os'; | ||
| export const isMacOS = parsedUserAgent.getOS()?.name?.toLowerCase() === 'macos'; |
There was a problem hiding this comment.
was this a typo earlier or the new version made this change?
raviteja83
reviewed
Dec 9, 2024
| } | ||
|
|
||
| function getDeviceType(device?: string, type?: string) { | ||
| return device && device.length > 0 ? `${device}_${type}` : type; |
There was a problem hiding this comment.
length check probably not needed
raviteja83
reviewed
Dec 9, 2024
| * @returns {Promise<UAParser.IOS>} OS name and version | ||
| */ | ||
| async function getOSFromUserAgent(): Promise<UAParser.IOS> { | ||
| const os = await parsedUserAgent.getOS().withClientHints(); |
There was a problem hiding this comment.
it might fail in older devices/browsers no? should we add a try catch and do feature check there as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ua-parser-jsto track correct device modelsSample user agents -
Pre-launch Checklist
Merging: