-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Configuration des workspaces pnpm #10838
Draft
bpetetot
wants to merge
15
commits into
dev
Choose a base branch
from
tech-return-of-pnpm-workspaces
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
bpetetot
force-pushed
the
tech-return-of-pnpm-workspaces
branch
2 times, most recently
from
December 17, 2024 15:27
0d3d8a5
to
8fa0f00
Compare
bpetetot
commented
Dec 18, 2024
bpetetot
force-pushed
the
tech-return-of-pnpm-workspaces
branch
3 times, most recently
from
December 18, 2024 14:32
1910374
to
353c577
Compare
Co-authored-by: Benjamin Petetot <benjamin.petetot@pix.fr>
bpetetot
force-pushed
the
tech-return-of-pnpm-workspaces
branch
from
December 18, 2024 14:37
353c577
to
b8ef0b3
Compare
bpetetot
force-pushed
the
tech-return-of-pnpm-workspaces
branch
from
December 18, 2024 15:03
3809e26
to
6e6f492
Compare
bpetetot
force-pushed
the
tech-return-of-pnpm-workspaces
branch
3 times, most recently
from
December 18, 2024 15:38
fa3df60
to
10cdc8d
Compare
bpetetot
force-pushed
the
tech-return-of-pnpm-workspaces
branch
3 times, most recently
from
December 18, 2024 15:49
508dc0c
to
3703f44
Compare
bpetetot
force-pushed
the
tech-return-of-pnpm-workspaces
branch
9 times, most recently
from
December 19, 2024 11:31
6148543
to
378b9c7
Compare
bpetetot
force-pushed
the
tech-return-of-pnpm-workspaces
branch
from
December 19, 2024 11:41
378b9c7
to
45b0bbb
Compare
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
this avoids installing all dependencies from subfolder
bpetetot
force-pushed
the
tech-return-of-pnpm-workspaces
branch
from
December 19, 2024 11:45
45b0bbb
to
5ac07bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
🎁 Proposition
Travail basé sur la PR #7155
🗒️ TODO
INSTALLATION.md
README.md
de chaque app Pixconfigure.sh
/docker
,/high-level-tests/e2e
/scripts
.husky
/.run
?🚀 Déploiement
Important
Pour le déploiement, il semble qu'il soit nécessaire d'avoir:
package.json
, la propriété"packageManager": "pnpm@9.15.0"
PNPM=true
🧦 Remarques
packageManager
dans lepackage.json
n'a pas été repris car il ne semble pas nécessaire d'après la documentation (bcf82f5)pnpm
par défaut. Donc il n'y plus besoin d'avoir un fork du buildpack comme dans la PR originale (https://github.com/Scalingo/nodejs-buildpack/blob/master/CHANGELOG.md#v245---2024-04-29)sed
en ajoutant une chaîne vide ('') après le -i.Important
Il est préférable de partir d'une "clean install" (sans node modules), sinon il faut au préalable les supprimer (dans tous les projets).
🚨 Il est nécessaire de supprimer le répertoire temporaire
$TMPDIR/embroider
🧰 Questions / Améliorations
Dans le package.json racine:
pnpm run
(run non obligatoire)pnpm --parallel
oucmd1 && cmd2
🎅 Pour tester
Environnements locaux
Vérifier l'utilisation sur:
Tests e2e
scripts/tests-e2e
qui execute les tests e2e dans des images dockerCommandes
Commandes racines:
pnpm install
pnpm lint
pnpm test
pnpm dev
Commandes
admin
pnpm dev
Commandes
api
pnpm dev
pnpm lint
pnpm test
pnpm db:reset
Commandes
audit-logger
pnpm dev
Commandes
certif
pnpm dev
Commandes
junior
pnpm dev
Commandes
mon-pix
pnpm dev
Commandes
orga
pnpm dev