[TECH] Rendre le code lié à l'authentification des applications plus clair (PIX-15876) #10906
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Le code lié à l'authentification des applications n'est pas très clair à lire, notamment pour les valeurs qui se trouvent dans le fichier
api/src/shared/config.js
où on distingue mal, notamment dans les diff des PR ou de l'historique Git, quelles sont les valeurs utilisées en production des valeurs surchargées pour les tests.🎁 Proposition
process.env.NODE_ENV === 'test'
), rendre les valeurs surchargées pour les tests explicites en les faisant commencer par le préfixetest-
process.env.NODE_ENV === 'test'
), surcharger uniquement les propriétés qui ont besoin de l’être🧦 Remarques
RAS
🎅 Pour tester