[FEATURE] Afficher la colonne "Écran de fin de test vu" sur la page de finalisation de session si le centre de certification n'utilise pas le portail surveillant (PIX-3748)

api/lib/domain/read-models/AllowedCertificationCenterAccess.js

@@ -69,6 +69,10 @@ class AllowedCertificationCenterAccess {
   isInWhitelist() {
     return features.pixCertifScoBlockedAccessWhitelist.includes(this.externalId.toUpperCase());
   }
+
+  hasEndTestScreenRemovalEnabled() {
+    return features.endTestScreenRemovalWhiteList.includes(this.id.toString());
+  }
 }
 
 module.exports = AllowedCertificationCenterAccess;

api/lib/infrastructure/serializers/jsonapi/certification-point-of-contact-serializer.js

@@ -26,6 +26,7 @@ module.exports = {
           'isAccessBlockedAgri',
           'relatedOrganizationTags',
           'habilitations',
+          'hasEndTestScreenRemovalEnabled',
         ],
       },
       typeForAttribute: function (attribute) {
@@ -50,6 +51,7 @@ module.exports = {
               isAccessBlockedLycee: access.isAccessBlockedLycee(),
               isAccessBlockedAEFE: access.isAccessBlockedAEFE(),
               isAccessBlockedAgri: access.isAccessBlockedAgri(),
+              hasEndTestScreenRemovalEnabled: access.hasEndTestScreenRemovalEnabled(),
             };
           }
         );

api/tests/acceptance/application/certification-point-of-contacts/certification-point-of-contacts_test.js

@@ -30,6 +30,7 @@ describe('Acceptance | Route | CertificationPointOfContact', function () {
       // then
       expect(response.statusCode).to.equal(200);
       expect(response.result.data.id).to.equal(userId.toString());
+      expect(response.result.included[0].attributes['has-end-test-screen-removal-enabled']).to.be.false;
     });
   });
 });

api/tests/unit/application/certification-point-of-contacts/certification-point-of-contact-controller_test.js

@@ -73,6 +73,7 @@ describe('Unit | Controller | certifications-point-of-contact-controller', funct
               'is-related-to-managing-students-organization': false,
               'related-organization-tags': [],
               habilitations: [],
+              'has-end-test-screen-removal-enabled': false,
             },
           },
         ],

api/tests/unit/domain/read-models/AllowedCertificationCenterAccess_test.js

@@ -688,4 +688,30 @@ describe('Unit | Domain | Read-Models | AllowedCertificationCenterAccess', funct
       expect(isScoManagingStudents).to.be.true;
     });
   });
+
+  context('#hasEndTestScreenRemovalEnabled', function () {
+    it('should return true when whitelisted', function () {
+      // given
+      const allowedCertificationCenterAccess = domainBuilder.buildAllowedCertificationCenterAccess({ id: 1 });
+      settings.features.endTestScreenRemovalWhiteList = ['1'];
+
+      // when
+      const result = allowedCertificationCenterAccess.hasEndTestScreenRemovalEnabled();
+
+      // then
+      expect(result).to.be.true;
+    });
+
+    it('should return false when not whitelisted', function () {
+      // given
+      const allowedCertificationCenterAccess = domainBuilder.buildAllowedCertificationCenterAccess({ id: 1 });
+      settings.features.endTestScreenRemovalWhiteList = ['2'];
+
+      // when
+      const result = allowedCertificationCenterAccess.hasEndTestScreenRemovalEnabled();
+
+      // then
+      expect(result).to.be.false;
+    });
+  });
 });

api/tests/unit/domain/services/end-test-screen-removal-service_test.js

@@ -4,16 +4,19 @@ const endTestScreenRemovalService = require('../../../../lib/domain/services/end
 
 describe('Unit | Domain | Service | EndTestScreenRemoval', function () {
   describe('#isEndTestScreenRemovalEnabledBySessionId', function () {
-    it('should call repository with sessionId', async function () {
+    it('should return value from repository', async function () {
       // given
       const sessionId = Symbol('sessionId');
-      sinon.spy(endTestScreenRemovalRepository, 'isEndTestScreenRemovalEnabledBySessionId');
+      sinon.stub(endTestScreenRemovalRepository, 'isEndTestScreenRemovalEnabledBySessionId');
+      endTestScreenRemovalRepository.isEndTestScreenRemovalEnabledBySessionId.withArgs(sessionId).resolves(false);
 
       // when
-      await endTestScreenRemovalService.isEndTestScreenRemovalEnabledBySessionId(sessionId);
+      const isEndTestScreenRemovalEnabled = await endTestScreenRemovalService.isEndTestScreenRemovalEnabledBySessionId(
+        sessionId
+      );
 
       // then
-      expect(endTestScreenRemovalRepository.isEndTestScreenRemovalEnabledBySessionId).to.be.calledWith(sessionId);
+      expect(isEndTestScreenRemovalEnabled).to.equals(false);
     });
   });
 

api/tests/unit/domain/usecases/authenticate-user_test.js

@@ -30,7 +30,7 @@ describe('Unit | Application | UseCase | authenticate-user', function () {
       updateLastLoggedAt: sinon.stub(),
     };
     sinon.stub(authenticationService, 'getUserByUsernameAndPassword');
-    sinon.stub(endTestScreenRemovalService, 'isEndTestScreenRemovalEnabledByCertificationCenterId');
+    sinon.stub(endTestScreenRemovalService, 'isEndTestScreenRemovalEnabledForSomeCertificationCenter');
   });
 
   it('should resolves a valid JWT access token when authentication succeeded', async function () {
@@ -161,15 +161,14 @@ describe('Unit | Application | UseCase | authenticate-user', function () {
     });
 
     context('when scope is pix-certif and user is not linked to any certification centers', function () {
-      it('should rejects an error when feature toggle is disabled for linked certification center', async function () {
+      it('should rejects an error when feature toggle is disabled for all certification center', async function () {
         // given
         const scope = appMessages.PIX_CERTIF.SCOPE;
         const user = domainBuilder.buildUser({ email: userEmail, certificationCenterMemberships: [] });
         authenticationService.getUserByUsernameAndPassword.resolves(user);
-        endTestScreenRemovalService.isEndTestScreenRemovalEnabledByCertificationCenterId.returns(true);
+        endTestScreenRemovalService.isEndTestScreenRemovalEnabledForSomeCertificationCenter.returns(false);
 
         const expectedErrorMessage = appMessages.PIX_CERTIF.NOT_LINKED_CERTIFICATION_MSG;
-
         // when
         const error = await catchErr(authenticateUser)({
           username: userEmail,
@@ -194,7 +193,7 @@ describe('Unit | Application | UseCase | authenticate-user', function () {
           certificationCenterMemberships: [Symbol('certificationCenterMembership')],
         });
 
-        endTestScreenRemovalService.isEndTestScreenRemovalEnabledByCertificationCenterId.returns(true);
+        endTestScreenRemovalService.isEndTestScreenRemovalEnabledForSomeCertificationCenter.returns(true);
         authenticationService.getUserByUsernameAndPassword.resolves(user);
         tokenService.createAccessTokenFromUser.returns(accessToken);
 

api/tests/unit/infrastructure/serializers/jsonapi/certification-point-of-contact-serializer_test.js

@@ -29,6 +29,7 @@ describe('Unit | Serializer | JSONAPI | certification-point-of-contact-serialize
         relatedOrganizationTags: ['tag1'],
         habilitations: [],
       });
+      allowedCertificationCenterAccess2.hasEndTestScreenRemovalEnabled = sinon.stub().returns(true);
       const certificationPointOfContact = domainBuilder.buildCertificationPointOfContact({
         id: 789,
         firstName: 'Buffy',
@@ -85,6 +86,7 @@ describe('Unit | Serializer | JSONAPI | certification-point-of-contact-serialize
                 { id: 1, name: 'Certif comp 1' },
                 { id: 2, name: 'Certif comp 2' },
               ],
+              'has-end-test-screen-removal-enabled': false,
             },
           },
           {
@@ -101,6 +103,7 @@ describe('Unit | Serializer | JSONAPI | certification-point-of-contact-serialize
               'is-access-blocked-agri': false,
               'related-organization-tags': ['tag1'],
               habilitations: [],
+              'has-end-test-screen-removal-enabled': true,
             },
           },
         ],
@@ -186,6 +189,7 @@ describe('Unit | Serializer | JSONAPI | certification-point-of-contact-serialize
                 'is-access-blocked-agri': false,
                 'related-organization-tags': [],
                 habilitations: [],
+                'has-end-test-screen-removal-enabled': false,
               },
             },
             {
@@ -202,6 +206,7 @@ describe('Unit | Serializer | JSONAPI | certification-point-of-contact-serialize
                 'is-access-blocked-agri': false,
                 'related-organization-tags': ['tag1'],
                 habilitations: [],
+                'has-end-test-screen-removal-enabled': false,
               },
             },
           ],

certif/app/components/session-finalization/completed-reports-information-step.hbs

@@ -14,17 +14,22 @@
         <th>Prénom</th>
         <th>N° de certification</th>
         <th>Signalement</th>
-        <th>
-          <div class="session-finalization-reports-information-step__row">
-            <div
-              class="session-finalization-reports-information-step__checker"
-              {{on "click" (fn @onAllHasSeenEndTestScreenCheckboxesClicked this.hasCheckedSomething)}}
-            >
-              <CertifCheckbox @state={{this.headerCheckboxStatus}} />
+        {{#if @shouldDisplayHasSeenEndTestScreenCheckbox}}
+          <th>
+            <div class="session-finalization-reports-information-step__row">
+              <div
+                class="session-finalization-reports-information-step__checker"
+                {{on "click" (fn @onAllHasSeenEndTestScreenCheckboxesClicked this.hasCheckedSomething)}}
+              >
+                <CertifCheckbox
+                  data-test-id="finalization-report-all-candidates-have-seen-end-test-screen"
+                  @state={{this.headerCheckboxStatus}}
+                />
+              </div>
+              Écran de fin du test vu
             </div>
-            Écran de fin du test vu
-          </div>
-        </th>
+          </th>
+        {{/if}}
       </tr>
     </thead>
     <tbody>
@@ -64,13 +69,15 @@
               {{/if}}
             </div>
           </td>
-          <td>
-            <CertifCheckbox
-              data-test-id="finalization-report-has-seen-end-test-screen_{{report.certificationCourseId}}"
-              @state={{if report.hasSeenEndTestScreen "checked" "unchecked"}}
-              {{on "click" (fn @onHasSeenEndTestScreenCheckboxClicked report)}}
-            />
-          </td>
+          {{#if @shouldDisplayHasSeenEndTestScreenCheckbox}}
+            <td>
+              <CertifCheckbox
+                data-test-id="finalization-report-has-seen-end-test-screen_{{report.certificationCourseId}}"
+                @state={{if report.hasSeenEndTestScreen "checked" "unchecked"}}
+                {{on "click" (fn @onHasSeenEndTestScreenCheckboxClicked report)}}
+              />
+            </td>
+          {{/if}}
         </tr>
       {{/each}}
     </tbody>

certif/app/controllers/authenticated/sessions/finalize.js

@@ -11,6 +11,7 @@ import trim from 'lodash/trim';
 
 export default class SessionsFinalizeController extends Controller {
   @service featureToggles;
+  @service currentUser;
 
   @service notifications;
 
@@ -28,6 +29,10 @@ export default class SessionsFinalizeController extends Controller {
     return this.featureToggles.featureToggles.isManageUncompletedCertifEnabled;
   }
 
+  get shouldDisplayHasSeenEndTestScreenCheckbox() {
+    return !this.currentUser.currentAllowedCertificationCenterAccess.hasEndTestScreenRemovalEnabled;
+  }
+
   get uncheckedHasSeenEndTestScreenCount() {
     return sumBy(this.session.completedCertificationReports.toArray(), (reports) =>
       Number(!reports.hasSeenEndTestScreen)

certif/app/models/allowed-certification-center-access.js

@@ -11,6 +11,7 @@ export default class AllowedCertificationCenterAccess extends Model {
   @attr() isAccessBlockedAgri;
   @attr() relatedOrganizationTags;
   @attr() habilitations;
+  @attr() hasEndTestScreenRemovalEnabled;
 
   get isSco() {
     return this.type === 'SCO';

certif/app/templates/authenticated/sessions/finalize.hbs

@@ -36,6 +36,7 @@
         @onHasSeenEndTestScreenCheckboxClicked={{this.toggleCertificationReportHasSeenEndTestScreen}}
         @onAllHasSeenEndTestScreenCheckboxesClicked={{this.toggleAllCertificationReportsHasSeenEndTestScreen}}
         @onIssueReportDeleteButtonClicked={{this.deleteCertificationIssueReport}}
+        @shouldDisplayHasSeenEndTestScreenCheckbox={{this.shouldDisplayHasSeenEndTestScreenCheckbox}}
       />
     {{/if}}
   </SessionFinalizationStepContainer>

certif/tests/acceptance/session-finalization_test.js

@@ -1,8 +1,9 @@
 import { module, test } from 'qunit';
-import { click, currentURL, fillIn, visit } from '@ember/test-helpers';
+import { click, currentURL, fillIn } from '@ember/test-helpers';
 import { setupApplicationTest } from 'ember-qunit';
 import { authenticateSession } from '../helpers/test-init';
 import clickByLabel from '../helpers/extended-ember-test-helpers/click-by-label';
+import { visit } from '@1024pix/ember-testing-library';
 
 import setupMirage from 'ember-cli-mirage/test-support/setup-mirage';
 
@@ -22,6 +23,7 @@ module('Acceptance | Session Finalization', function (hooks) {
       isAccessBlockedLycee: false,
       isAccessBlockedAEFE: false,
       isAccessBlockedAgri: false,
+      hasEndTestScreenRemovalEnabled: false,
     });
     certificationPointOfContact = server.create('certification-point-of-contact', {
       firstName: 'Buffy',
@@ -78,6 +80,15 @@ module('Acceptance | Session Finalization', function (hooks) {
       assert.equal(currentURL(), `/sessions/${session.id}/finalisation`);
     });
 
+    test('it should display the end screen column when the center has no access to the supervisor space', async function (assert) {
+      // when
+      server.create('feature-toggle', { isEndTestScreenRemovalEnabled: true });
+      const screen = await visit(`/sessions/${session.id}/finalisation`);
+
+      // then
+      assert.dom(screen.queryByText('Écran de fin du test vu')).exists();
+    });
+
     module('When certificationPointOfContact click on "Finaliser" button', function () {
       module('when there is no certification issue reports', function () {
         test('it should show "Ajouter ?" button', async function (assert) {