-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Formater le code de pix-certif avec Prettier. #3935
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm deploying this PR to these urls:
Please check it out! |
octo-topi
force-pushed
the
tech-format-code-prettier-certif
branch
6 times, most recently
from
January 12, 2022 15:09
d2d18de
to
efe5ff4
Compare
octo-topi
added
👀 Tech Review Needed
team-certif
and removed
Development in progress
labels
Jan 13, 2022
clemlatz
approved these changes
Jan 13, 2022
certif/app/components/issue-report-modal/in-challenge-certification-issue-report-fields.hbs
Outdated
Show resolved
Hide resolved
MathieuGilet
force-pushed
the
tech-format-code-prettier-certif
branch
from
January 13, 2022 15:58
b38af21
to
2086065
Compare
Pour comprendre la correction du test Cypress il faut comprendre que le code
Va produire le HTML suivant
Il y a deux problèmes ici:
|
octo-topi
force-pushed
the
tech-format-code-prettier-certif
branch
from
January 14, 2022 08:11
2086065
to
39dfc42
Compare
aceol
approved these changes
Jan 14, 2022
octo-topi
force-pushed
the
tech-format-code-prettier-certif
branch
from
January 14, 2022 09:21
39dfc42
to
f498563
Compare
Libouk
approved these changes
Jan 14, 2022
octo-topi
added
🚀 Ready to Merge
Tech Review OK
and removed
👀 Tech Review Needed
labels
Jan 14, 2022
pix-service-auto-merge
force-pushed
the
tech-format-code-prettier-certif
branch
from
January 14, 2022 09:22
f498563
to
25faeb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Voir #3494
Pix-certif est la seule application ayant passé aux travers des mailles du filet.
🎁 Solution
Voir #3557 pour la version front
Le test E2E suivant échoue
cy.get('.app-modal-body__contextual').should('contain', `La case "Écran de fin du test vu" n'est pas cochée pour ${endTestForgottenCount} candidat(s)`);
Alors que contains ne prend pas en compte les newline (depuis la v4, et on est en v5.6.0) 🤔
https://dashboard.cypress.io/projects/g2rfqp/runs/19472/test-results/245b9aa4-ee71-4996-b319-00d5ccf720c7
🌟 Remarques
Remplacement de
ember-cli-template-lint
(déprécié) parember-template-lint
Il y a aussi des corrections hbs hors formatage (peut-être dues au décalage entre
ember-cli-template-lint
ettemplate-lint
) , que j'ai désactivées pour l'instant mais mériteraient d'être traitées.J'ai également supprimé le preset
octane
, car il n'est plus référencé.Déplacement de la librairie
ember-api-action
dans lesdevDependencies
pour suivre la convention.🎅 Pour tester
Vérifier que la CI passe.