[TECH] Supprimer la métrique de couverture de code plus disponible #6552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles via les liens suivants : |
alexandrecoin
approved these changes
Jul 6, 2023
yannbertrand
reviewed
Jul 6, 2023
| - db/migrations | ||
| - db/seeds | ||
| - scripts | ||
| - nyc.config.js | ||
| - codemods |
There was a problem hiding this comment.
Volontaire de supprimer codemods ?
There was a problem hiding this comment.
Yep, c'est du ménage pas fait à l'époque
yannbertrand
approved these changes
Jul 6, 2023
VincentHardouin
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
L'outil de mesure de la couverture de code (nyc) ne supporte pas (encore) ESM, et ce depuis 3 ans.
istanbuljs/nyc#1287
Or nous avons migré vers ESM.
Donc cet outil est inutilisable.
🤖 Proposition
Le supprimer
🌈 Remarques
C'est un peu triste
💯 Pour tester
Vérifier que la CI passe