Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix memory leaks, add rerun-if #10

Merged
merged 1 commit into from
Jan 15, 2020
Merged

fix memory leaks, add rerun-if #10

merged 1 commit into from
Jan 15, 2020

Conversation

nlhepler
Copy link
Contributor

also rustfmt

@nlhepler nlhepler requested a review from pmarks January 15, 2020 01:01
pmarks
pmarks approved these changes Jan 15, 2020
View reviewed changes
Copy link
Contributor

@pmarks pmarks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@nlhepler nlhepler merged commit 89a94cb into master Jan 15, 2020
@nlhepler nlhepler deleted the lh/fix-memleak branch January 15, 2020 01:16
sjackman added a commit that referenced this pull request Aug 13, 2020
@sjackman
Fix warnings and treat warnings as errors (#10)
b864977 
Add -Werror to CXXFLAGS.
Remove register keyword.
Comment out unused function arguments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmarks pmarks pmarks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nlhepler @pmarks