Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude meta with empty post meta keys #3516

Merged
merged 5 commits into from
Jul 4, 2023
Merged

Exclude meta with empty post meta keys #3516

merged 5 commits into from
Jul 4, 2023

Conversation

MARQAS
Copy link
Contributor

@MARQAS MARQAS commented Jun 27, 2023

Description of the Change

This PR will exclude the post meta with empty or NULL meta keys

Closes #3470

How to test the Change

  • Create a post
  • Add empty post meta to it via code.
  • Run the sync
  • Notice that the sync will be successful

Changelog Entry

Fixed - indexing a post with empty post meta key

Credits

Props @MARQAS

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@MARQAS MARQAS added this to the 4.7.0 milestone Jun 29, 2023
felipeelia
felipeelia requested changes Jul 4, 2023
View reviewed changes
tests/php/indexables/TestPost.php Outdated Show resolved Hide resolved
@felipeelia felipeelia modified the milestones: 4.7.0, 4.6.1 Jul 4, 2023
@felipeelia felipeelia merged commit f38785c into develop Jul 4, 2023
8 checks passed
@felipeelia felipeelia deleted the fix/3470-empty-post-meta-key branch July 4, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felipeelia felipeelia felipeelia requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.1
Development

Successfully merging this pull request may close these issues.

BUG: indexing a post with empty post meta key
2 participants
@MARQAS @felipeelia