PR feedback improvements.

10up · Apr 6, 2023 · 228f79a · 228f79a
1 parent 91e9fc6
commit 228f79a
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 11 deletions.
diff --git a/includes/Classifai/Admin/Notifications.php b/includes/Classifai/Admin/Notifications.php
@@ -56,7 +56,7 @@ public function maybe_render_notices() {
 			<div data-notice="plugin-activation" class="notice notice-success is-dismissible">
 				<div id="classifai-activation-notice">
 					<div class="classifai-logo">
-						<img src="<?php echo esc_url( CLASSIFAI_PLUGIN_URL . 'assets/img/classifai.png' ); ?>" alt="ClassifAI" />
+						<img src="<?php echo esc_url( CLASSIFAI_PLUGIN_URL . 'assets/img/classifai.png' ); ?>" alt="<?php esc_attr_e( 'ClassifAI', 'classifai' ); ?>" />
 					</div>
 					<h3 class="classifai-activation-message">
 						<?php esc_html_e( 'Congratulations, the ClassifAI plugin is now activated.', 'classifai' ); ?>

diff --git a/includes/Classifai/Admin/templates/classifai-header.php b/includes/Classifai/Admin/templates/classifai-header.php
@@ -12,7 +12,7 @@
 	<div class="classifai-header-layout">
 		<div id="classifai-branding">
 			<div id="classifai-logo">
-				<img src="<?php echo esc_url( CLASSIFAI_PLUGIN_URL . 'assets/img/classifai.png' ); ?>" alt="ClassifAI" />
+				<img src="<?php echo esc_url( CLASSIFAI_PLUGIN_URL . 'assets/img/classifai.png' ); ?>" alt="<?php esc_attr_e( 'ClassifAI', 'classifai' ); ?>" />
 			</div>
 		</div>
 		<div id="classifai-header-controls">
@@ -46,8 +46,8 @@
 				</a>
 				<template id="help-menu-template">
 					<div class="classifai-help-menu">
-						<a class="classifai-help-menu__menu-item" target="_blank" href="https://github.com/10up/classifai#frequently-asked-questions"><?php esc_html_e( 'FAQs', 'classifai' ); ?></a>
-						<a class="classifai-help-menu__menu-item" target="_blank"  href="https://github.com/10up/classifai/issues/new/choose"><?php esc_html_e( 'Report issue/enhancement', 'classifai' ); ?></a>
+						<a class="classifai-help-menu__menu-item" target="_blank" rel="noopener noreferrer" href="https://github.com/10up/classifai#frequently-asked-questions"><?php esc_html_e( 'FAQs', 'classifai' ); ?></a>
+						<a class="classifai-help-menu__menu-item" target="_blank" rel="noopener noreferrer" href="https://github.com/10up/classifai/issues/new/choose"><?php esc_html_e( 'Report issue/enhancement', 'classifai' ); ?></a>
 					</div>
 				</template>
 			</div>
@@ -70,7 +70,7 @@
 	<?php
 	foreach ( $classifai_header_menu as $key => $value ) {
 		?>
-		<a href="<?php echo esc_url( admin_url( 'admin.php?page=' . $key ) ); ?>" class="nav-tab <?php echo ( $classifai_page === $key ) ? 'nav-tab-active' : ''; ?>">
+		<a href="<?php echo esc_url( admin_url( 'admin.php?page=' . $key ) ); ?>" class="nav-tab <?php echo esc_attr( ( $classifai_page === $key ) ? 'nav-tab-active' : '' ); ?>">
 			<?php echo esc_html( $value ); ?>
 		</a>
 		<?php

diff --git a/includes/Classifai/Admin/templates/onboarding-step-four.php b/includes/Classifai/Admin/templates/onboarding-step-four.php
@@ -35,9 +35,9 @@ function( $feature ) use ( $enabled_features, $configured_providers ) {
 require_once 'onboarding-header.php';
 ?>
 
-<h1 class="classifai-setup-title">
+<h2 class="classifai-setup-title">
 	<?php esc_html_e( 'ClassifAI configured successfully!', 'classifai' ); ?>
-</h1>
+</h2>
 <?php
 foreach ( $features as $key => $feature ) {
 	if ( empty( $feature['title'] ) || empty( $feature['features'] ) ) {

diff --git a/includes/Classifai/Admin/templates/onboarding-step-one.php b/includes/Classifai/Admin/templates/onboarding-step-one.php
@@ -28,9 +28,9 @@
 require_once 'onboarding-header.php';
 ?>
 
-<h1 class="classifai-setup-title">
+<h2 class="classifai-setup-title">
 	<?php esc_html_e( 'Set up ClassifAI to meet your needs', 'classifai' ); ?>
-</h1>
+</h2>
 <?php
 foreach ( $features as $key => $feature ) {
 	if ( empty( $feature['title'] ) || empty( $feature['features'] ) ) {

diff --git a/src/scss/admin.scss b/src/scss/admin.scss
@@ -437,9 +437,11 @@ input.classifai-button {
 			margin-top: 20px;
 		}
 
-		h1.classifai-setup-title {
+		h2.classifai-setup-title {
 			font-size: 22px;
 			padding: 0px;
+			font-weight: 400;
+			margin: 0px;
 		}
 
 		.classifai-step1-content,
@@ -513,7 +515,7 @@ input.classifai-button {
 				margin-top: 20px;
 			}
 
-			h1.classifai-setup-title {
+			h2.classifai-setup-title {
 				text-align: center;
 			}
 		}