Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/hookdocs workflow #189

Merged
merged 7 commits into from
Mar 4, 2020
Merged

Add/hookdocs workflow #189

merged 7 commits into from
Mar 4, 2020

Conversation

jeffpaul
Copy link
Member

Description of the Change

This PR introduces the files needed to generate hook docs and deploy them to GitHub Pages for ClassifAI, similar to what was created for Distributor.

Alternate Designs

n/a

Benefits

More fully communicates the extensibility of ClassifAI via a hook documentation site.

Possible Drawbacks

We may not have JSDoc-formatted docblocks for our hooks, in which case we'll want to ensure those get added as well so that the hookdoc site is as complete and accurate as possible.

Verification Process

Manually compared to set up for hookdoc generation on Distributor.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

n/a, mea culpa.

Changelog Entry

### Added
- Fully documented hooks and filters via new Hook Documentation site

@jeffpaul jeffpaul added the needs:documentation This requires documentation. label Feb 27, 2020
@jeffpaul jeffpaul requested a review from helen February 27, 2020 19:41
@jeffpaul jeffpaul self-assigned this Feb 27, 2020
on:
push:
branches:
- develop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to master so that the hook docs don't update until we actually are ready to release a new version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@helen should we make a similar change to Distributor and ElasticPress?

package.json Outdated Show resolved Hide resolved
jeffpaul and others added 2 commits March 4, 2020 16:29
Co-Authored-By: Helen Hou-Sandi <helen.y.hou@gmail.com>
@helen helen merged commit 84db7a7 into develop Mar 4, 2020
@helen helen deleted the add/hookdocs-workflow branch March 4, 2020 22:46
@helen helen mentioned this pull request Mar 5, 2020
6 tasks
@jeffpaul jeffpaul modified the milestones: 1.6.0, 1.5.1 Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:documentation This requires documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants