Move doc deploy action to the release workflow #192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Moves the doc build/deployment to the same workflow as the release to stable, since both run on master and are a signal of an impending new release. Realized this as I was changing the doc workflow to go back to running on master instead of develop. Also fixes a warning about
version
being deprecated in favor ofnode-version
.Alternate Designs
Leaving as-is, which is more resource intensive as it spins up two machines and runs
npm install
on both.Benefits
Faster workflow run, less maintenance.
Possible Drawbacks
If we decide later they shouldn't run on the same trigger we'll have to split it back out.
Verification Process
n/a, basically hoping it'll work.
Checklist:
Applicable Issues
See #191
Changelog Entry
n/a