Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/move linting to GH Actions #226

Merged
merged 3 commits into from
Oct 6, 2020
Merged

Add/move linting to GH Actions #226

merged 3 commits into from
Oct 6, 2020

Conversation

helen
Copy link
Contributor

@helen helen commented Sep 29, 2020

Description of the Change

As advertised - good for annotations and working on consolidating CI into one place.

Alternate Designs

Leaving on Travis.

Benefits

Single interface, more team experience and growing ecosystem.

Possible Drawbacks

Not sure yet, initial run when this PR is opened might tell us some things :)

Verification Process

This is copy-pasted from another working source, I did not try it locally, just going to let it run live since it's a PR.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Also see #215

Changelog Entry

Not really release-relevant

@helen helen added this to the 1.6.0 milestone Sep 29, 2020
@jeffpaul jeffpaul merged commit a5c786e into develop Oct 6, 2020
@jeffpaul jeffpaul deleted the add/ci-linting branch November 10, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants