Ensure manual image scanning still works if the automatic scanning is turned off #233
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
If either the Automatically Caption Images or Automatically Tag Images settings are turned off, we still output the manual scan/rescan buttons when editing an individual image. But those buttons don't work, as we check the aforementioned settings when making a request to get image details and if those settings are disabled, we don't request the proper image details.
This PR fixes that, so if manual scanning is triggered, this overrides the automatic setting, so even if that setting is turned off, the manual scan will still work. Automatic scanning for newly uploaded images still respect that setting though, this only applies to manual scans.
Alternate Designs
We could remove the manual scan buttons all together if the automatic scanning is turned off
Benefits
Manual scanning works properly even if the automatic scanning is turned off. At the moment, those buttons show but won't work properly
Possible Drawbacks
None
Verification Process
Checklist:
Applicable Issues
#232