Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't default to the post post type, if no other post types are selected #247

Merged
merged 5 commits into from
Oct 26, 2020

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented Oct 22, 2020

Description of the Change

For Language Processing, if no post types are selected in the settings, we default to still using the post post type. If a user has decided to not select any post types, we should respect that decision and not run Language Processing on posts anyway.

Alternate Designs

None

Benefits

Settings will be respected and Language Processing won't happen on post types that haven't been selected

Possible Drawbacks

None

Verification Process

  1. Go to the Language Processing settings
  2. Deselect all the options under Post Types to Classify
  3. Ensure the options below that are still enabled
  4. Go and add a new post and save it
  5. Ensure no classification happened and no Classify taxonomies are shown

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#246

@jeffpaul jeffpaul added this to the 1.6.0 milestone Oct 23, 2020
@jeffpaul jeffpaul added the type:bug Something isn't working. label Oct 23, 2020
@jeffpaul jeffpaul merged commit 3bf3899 into develop Oct 26, 2020
@jeffpaul jeffpaul deleted the feature/supported-post-types branch October 26, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language Processing still runs on Posts if you have no post types selected in the settings
3 participants