Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Passing VIPCS check #287

Merged
merged 6 commits into from
Jun 7, 2021
Merged

Passing VIPCS check #287

merged 6 commits into from
Jun 7, 2021

Conversation

dinhtungdu
Copy link
Contributor

Description of the Change

This PR is a replacement for #211 which ensures ClassifAI passes the phpcs check using WordPress-VIP-Go standard.

Note that I excluded testst folder in this check.

Verification Process

Install VIPCS and run this command:

phpcs --standard=WordPress-VIP-Go -s --extensions=php --ignore=node_modules,vendor,tests .

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

#182

Changelog Entry

@dinhtungdu dinhtungdu self-assigned this Jun 4, 2021
@dinhtungdu dinhtungdu added the type:enhancement New feature or request. label Jun 4, 2021
@dinhtungdu dinhtungdu requested a review from dkotter June 4, 2021 09:38
@jeffpaul jeffpaul added this to the 1.7.0 milestone Jun 4, 2021
@jeffpaul jeffpaul linked an issue Jun 4, 2021 that may be closed by this pull request
Submit 1.5.0 to VIP for review #182
Closed
@jeffpaul jeffpaul mentioned this pull request Jun 4, 2021
Closed
6 tasks
dkotter
dkotter requested changes Jun 4, 2021
View reviewed changes
autoload.php Outdated Show resolved Hide resolved
@dinhtungdu dinhtungdu requested a review from dkotter June 7, 2021 02:31
@jeffpaul jeffpaul merged commit 70ae0bf into develop Jun 7, 2021
@jeffpaul jeffpaul deleted the fix/vipcs branch June 7, 2021 20:21
@jeffpaul jeffpaul mentioned this pull request Oct 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@dinhtungdu dinhtungdu

Labels
type:enhancement New feature or request.
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

Submit 1.5.0 to VIP for review
3 participants
@dinhtungdu @dkotter @jeffpaul