fix/344: Fix hook docs deployment. #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamdharmesh
requested review from
a team and
Sidsector9
and removed request for
a team
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As reported on #344, hook docs deployment is failing currently. This PR contains changes to fix it.
This PR changes the GH Actions used to publish to the gh-pages branch. Previously, we were using https://github.com/maxheld83/ghpages, and this PR changes to use https://github.com/peaceiris/actions-gh-pages
Closes #344
Alternate Designs
Maybe debug an issue in the existing action and fix it or choose any other GH action to deploy to GH pages.
Possible Drawbacks
n/a
Verification Process
Hook Docs should deploy correctly once anything is pushed to the trunk.
Checklist:
Changelog Entry
Credits
Props @iamdharmesh