Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Utilize get_asset_info #421

Merged
merged 6 commits into from
Apr 27, 2023
Merged

Utilize get_asset_info #421

merged 6 commits into from
Apr 27, 2023

Conversation

Spoygg
Copy link

@Spoygg Spoygg commented Mar 28, 2023

Description of the Change

Adds #414

Closes #414

How to test the Change

Changelog Entry

Changed - Replaced manual/constant version and dependencies in wp_enqueue_script with get_asset_info

Credits

Props @Spoygg

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@Spoygg Spoygg requested review from a team, dkotter and jeffpaul as code owners March 28, 2023 07:16
@Spoygg Spoygg mentioned this pull request Mar 28, 2023
Closed
1 task
@jeffpaul jeffpaul added this to the 1.9.0 milestone Apr 3, 2023
@jeffpaul jeffpaul removed their request for review April 3, 2023 20:51
@dkotter dkotter modified the milestones: 1.9.0, 2.0.0 Apr 4, 2023
@dkotter dkotter merged commit 1d7dcb2 into develop Apr 27, 2023
@dkotter dkotter deleted the feature/utilitze-get_asset_info branch April 27, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkotter dkotter dkotter approved these changes

Assignees

@Spoygg Spoygg

Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Utilize get_asset_info where it makes sense
4 participants
@Spoygg @dkotter @jeffpaul @ivanicsf