Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we don't send unnecessary API requests to NLU #455

Merged
merged 4 commits into from
May 18, 2023
Merged

Ensure we don't send unnecessary API requests to NLU #455

merged 4 commits into from
May 18, 2023

Commits on May 10, 2023

  1. Update our abstract can_register method to not be abstract anymore an… 

    …d to be a wrapper for the new is_configured method. For all existing providers that had the same can_register check, remove that method from the child class so they will rely on the parent method
    @dkotter
    dkotter committed May 10, 2023
    Configuration menu
    Copy the full SHA
    7d5f43a View commit details
    Browse the repository at this point in the history

  2. Update how we store authentication data for NLU to match what we do i… 

    …n other providers. Update the can_register method of NLU to match more closely to other providers as well
    @dkotter
    dkotter committed May 10, 2023
    Configuration menu
    Copy the full SHA
    0517c34 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Merge branch 'develop' into fix/415

    @dkotter
    dkotter committed May 18, 2023
    Configuration menu
    Copy the full SHA
    4f77927 View commit details
    Browse the repository at this point in the history

  2. Remove unneeded method as we can rely on the parent method instead

    @dkotter
    dkotter committed May 18, 2023
    Configuration menu
    Copy the full SHA
    4a55ebc View commit details
    Browse the repository at this point in the history