Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all custom hooks have proper docblocks #470

Merged
merged 3 commits into from
May 26, 2023
Merged

Ensure all custom hooks have proper docblocks #470

merged 3 commits into from
May 26, 2023

Conversation

dkotter
Copy link
Collaborator

@dkotter dkotter commented May 26, 2023

Description of the Change

I noticed that we introduced a few new filters in the last release but those filters did not have proper docblocks. This means they aren't showing within our automated documentation site: https://10up.github.io/classifai/

I did a scan of our codebase and found similar issues with a handful of our existing actions and filters as well, so this PR cleans all of those up. I've also added a link to this doc site at the top of our readmes.

How to test the Change

If desired, you can build the doc site locally by running npm run build:docs and ensuring all hooks show properly there

Changelog Entry

Fixed - Add proper docblocks to all custom hooks to ensure those show properly in our documentation site

Credits

Props @dkotter

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@dkotter dkotter added this to the 2.2.1 milestone May 26, 2023
@dkotter dkotter requested a review from a team as a code owner May 26, 2023 19:22
@dkotter dkotter self-assigned this May 26, 2023
@dkotter dkotter requested a review from jeffpaul as a code owner May 26, 2023 19:22
Copy link
Member

@jeffpaul jeffpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements for docs, thanks!

@dkotter dkotter merged commit c5411af into develop May 26, 2023
@dkotter dkotter deleted the fix/hooks branch May 26, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants