Ensure Classification preview works as expected #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a preview, which leads to JS errors. Remove code that isn't needed. Fix a deprecation warning
dkotter
requested review from
Sidsector9
and removed request for
a team and
jeffpaul
… instead of relying on a single method, as they have different things to output
Sidsector9
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As described in #663, when triggering the Classification Preview functionality, an undefined text message shows before the results are shown. This is a new bug introduced coming out of #611.
This PR fixes that by ensuring we trigger the right preview function depending on which Provider has been selected, whereas previously we were firing off both the NLU and Embeddings preview functions, resulting in the error.
Closes #663
How to test the Change
Changelog Entry
Credits
Props @dkotter, @QAharshalkadu
Checklist: