Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the embeddings provider to be used by features other than classification. #766

Merged
merged 2 commits into from
May 10, 2024

Conversation

iamdharmesh
Copy link
Member

Description of the Change

PR makes some minor necessary changes to allow the embedding provider to be used by features other than classification.

How to test the Change

Nothing specific to test here, confirming the Classification feature works as expected would be enough.

Changelog Entry

Changed - Allow the embeddings provider to be used by features other than classification.

Credits

Props @iamdharmesh

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

@iamdharmesh iamdharmesh requested review from dkotter, jeffpaul and a team as code owners May 10, 2024 09:05
@iamdharmesh iamdharmesh self-assigned this May 10, 2024
@iamdharmesh iamdharmesh added this to the 3.1.0 milestone May 10, 2024
@github-actions github-actions bot added the needs:code-review This requires code review. label May 10, 2024
@dkotter dkotter merged commit 75d4054 into develop May 10, 2024
14 checks passed
@dkotter dkotter deleted the ehnancement/generic-embeddings branch May 10, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:code-review This requires code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants